overwrite addBatchSinglePlace and addBatchSinglePlaceNotNull in AggregateFunctionCountNotNullUnary

[windtalker]

What problem does this PR solve?

Issue Number: ref #9146

Problem Summary:

What is changed and how it works?

AggregateFunctionCountNotNullUnary does not overwrite addBatchSinglePlace and addBatchSinglePlaceNotNull, so the code path will be

tiflash/dbms/src/AggregateFunctions/IAggregateFunction.h

Lines 267 to 289 in 0853523

	void addBatchSinglePlace(
	size_t start_offset,
	size_t batch_size,
	AggregateDataPtr place,
	const IColumn ** columns,
	Arena * arena,
	ssize_t if_argument_pos = -1) const override
	{
	if (if_argument_pos >= 0)
	{
	const auto & flags = assert_cast<const ColumnUInt8 &>(*columns[if_argument_pos]).getData();
	for (size_t i = start_offset; i < start_offset + batch_size; ++i)
	{
	if (flags[i])
	static_cast<const Derived *>(this)->add(place, columns, i, arena);
	}
	}
	else
	{
	for (size_t i = start_offset; i < start_offset + batch_size; ++i)
	static_cast<const Derived *>(this)->add(place, columns, i, arena);
	}
	}

In fact, AggregateFunctionCountNotNullUnary can be optimized by count the element number in batch like AggregateFunctionCount by overwrite addBatchSinglePlace and addBatchSinglePlaceNotNull

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[windtalker]

/test pull-unit-test

[yibin87]

What're the differences between these two functions? Only the way that the nullmap is passed?

[windtalker]

What're the differences between these two functions? Only the way that the nullmap is passed?

addBatchSinglePlace is the public function that will be called from Aggregator directly, addBatchSinglePlaceNotNull is kind of a protect function that usually be called inside AggregateFunctionXXX.

[gengliqi]

How about calling addBatchSinglePlaceNotNull here directly?

[windtalker]

Good idea.

[yibin87]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gengliqi,yibin87]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-10-29 16:09:26.231694667 +0000 UTC m=+366079.070850213: ☑️ agreed by gengliqi.
• 2024-10-30 01:11:32.528145168 +0000 UTC m=+398605.367300709: ☑️ agreed by yibin87.