Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize logical operator function in TiFlash #9146

Closed
windtalker opened this issue Jun 13, 2024 · 0 comments · Fixed by #9523
Closed

optimize logical operator function in TiFlash #9146

windtalker opened this issue Jun 13, 2024 · 0 comments · Fixed by #9523
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@windtalker
Copy link
Contributor

windtalker commented Jun 13, 2024 •
edited by JaySon-Huang
Loading

Enhancement

Running query

explain analyze select count(ol_i_id), count(ol_supply_w_id), count(ol_delivery_d) from order_line
where
    ol_i_id <= 100000
and ol_supply_w_id <= 1500
and (ol_delivery_d >= "2021-12-27 09:25:34" or ol_delivery_d is NULL)

Where order_line has 452038522 rows, the profile shows logical operator is very slow in TiFlash(takes up almost 70% cpu time), which is not expected.
Screenshot 2024-06-13 at 16 10 56
@windtalker windtalker added the type/enhancement The issue or PR belongs to an enhancement. label Jun 13, 2024
@windtalker windtalker mentioned this issue Oct 14, 2024
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot closed this as completed in 9c44999 Oct 17, 2024
@windtalker windtalker mentioned this issue Oct 18, 2024
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Oct 18, 2024
@windtalker
fix issue introduced by #9523 (#9543)
73b6f5f 
ref #9146

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
This was referenced Oct 28, 2024
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Oct 30, 2024
@windtalker
overwrite addBatchSinglePlace and addBatchSinglePlaceNotNull in `…
43a0a69 
…AggregateFunctionCountNotNullUnary` (#9563)

ref #9146

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
ti-chi-bot bot added a commit that referenced this issue Nov 4, 2024
@windtalker @ti-chi-bot
Add two value logical op (#9560)
fd20bd0 
ref #9146

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
yibin87 pushed a commit to yibin87/tiflash that referenced this issue Nov 6, 2024
@windtalker @ti-chi-bot
Add two value logical op (pingcap#9560)
7f686cd 
ref pingcap#9146

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@JaySon-Huang JaySon-Huang mentioned this issue Feb 27, 2025
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Feb 27, 2025
@Lloyd-Pottiger
*: enable null_as_false when build push down filter in late materia…
ec71fec 
…lization (#9918)

ref #9146

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refine logical op in TiFlash windtalker/tiflash
1 participant
@windtalker