-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: enable null_as_false
when build push down filter in late materialization
#9918
*: enable null_as_false
when build push down filter in late materialization
#9918
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Is this change only affect writing tests? |
It can help improve performance in some cases. |
Can you elaborate more about how the change affects the behavior of tiflash in the "What is changed and how it works" part? |
done |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #9146
Problem Summary:
What is changed and how it works?
Enable
two_value_and
in late materialization, more details in #9560.PhysicalFilter::build
andexecutePushedDownFilter
both have enabletwo_value_and
.Ref #9741
Check List
Tests
Side effects
Documentation
Release note