-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 1.13 to master #5696
Merge 1.13 to master #5696
Conversation
Signed-off-by: Gromadzki, Tomasz <tomasz.gromadzki@intel.com>
Make use of extra tests for packages we have up our sleeve. Since we're running this test on Fedora, we'd have to also extend list of installed packages, for these new checks to work. Make the script a little more verbose, in the process.
'build-and-test-pmdk-packages.sh' script was using the extra checks for packages, but now they are all part of 'run-build-package.sh'. Packages GHA workflow now use the old 'MAKE_PKG' command.
update RockyLinux 8 image to work with new MAKE_PKG scripts. Don't execute rpm checks on Fedora - it's duplicated now by RockyLinux
common: enable manual trigger of some builds
Update packages testing
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Temporary solution until a platform supporting the tested functionality is ready
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
test: disable test due to pmem#5641 (ex_libpmem2/TEST5)
Fedora builds fails regularyly but randomly. Builds have been moved to nightly build to avoid CI/GHA being blcked with many false positives. Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
test: disable pmem2_badblock tests due to pmem#5636
test: disable test until pmem#5599 fixed
common: move Fedora builds to nightly builds
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Disable avx512f tests until Valgrind until Valigrind will provide support for avx512f instruction. See: pmem#5640 Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
test: enable Python tests (short+medium) to be run on PMem
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
test: print out build system version
Execute build in a paralel way, but execute test one by one. Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
test: speedup tests on PMem
test: disable pmem2_mover/TEST[6-8] for drd
Codecov Report
@@ Coverage Diff @@
## master #5696 +/- ##
==========================================
+ Coverage 74.26% 74.28% +0.02%
==========================================
Files 146 146
Lines 22132 22134 +2
Branches 3705 3705
==========================================
+ Hits 16436 16442 +6
+ Misses 5696 5692 -4 |
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
common: fix typo in GHA script
Release 1.13.1 rc2
7daa87f
to
dfbacb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 49 of 50 files at r1, all commit messages.
Reviewable status: 49 of 50 files reviewed, 8 unresolved discussions (waiting on @janekmi)
ChangeLog
line 18 at r1 (raw file):
- pmem2_mover (partially fixed) (#5595, #5686, #5694) - pmem2_vm_reservation (#5592)
I think #5650 shall be documented differently.
We disable these tests as we do not have HW to execute them, not just because they fail.
ChangeLog
line 21 at r1 (raw file):
- Fixes failing tests: - obj_tx_alloc_mt (#5680) - pmem2_integration (#5637)
#5637 is a pmem2 fix, not only a test fix..
src/test/obj_sync/TEST2
line 19 at r1 (raw file):
#require_valgrind 3.10 #configure_valgrind helgrind force-enable configure_valgrind drd force-disable
See #5700.
src/test/obj_sync/TEST5
line 19 at r1 (raw file):
#require_valgrind 3.10 #configure_valgrind drd force-enable configure_valgrind drd force-disable
See #5700.
src/test/obj_sync/TEST6
line 19 at r1 (raw file):
#require_valgrind 3.10 #configure_valgrind helgrind force-enable configure_valgrind drd force-disable
See #5700.
src/test/pmem2_integration/TESTS.py
line 3 at r1 (raw file):
#!../env.py # SPDX-License-Identifier: BSD-3-Clause # Copyright 2019-2023, Intel Corporation
No changes in this file.
Suggestion:
2019-2021
src/test/pmem2_map_from_existing/TESTS.py
line 3 at r1 (raw file):
#!../env.py # SPDX-License-Identifier: BSD-3-Clause # Copyright 2020-2023, Intel Corporation
No changes in this file
Suggestion:
Copyright 2020-2021
src/test/pmem2_map_prot/TESTS.py
line 75 at r1 (raw file):
@t.require_architectures('x86_64') # XXX disable the test until https://github.com/pmem/pmdk/issues/5599 is fixed.
It seems that #5599 has already been fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 50 files at r1.
Reviewable status: all files reviewed, 8 unresolved discussions (waiting on @janekmi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 50 of 50 files at r1, all commit messages.
Reviewable status: all files reviewed, 8 unresolved discussions (waiting on @janekmi)
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
common: ChangeLog update based on review feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @janekmi)
ChangeLog
line 18 at r1 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
I think #5650 shall be documented differently.
We disable these tests as we do not have HW to execute them, not just because they fail.
Resolved by #5703
ChangeLog
line 21 at r1 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
#5637 is a pmem2 fix, not only a test fix..
Resolved by #5703
src/test/obj_sync/TEST2
line 19 at r1 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
See #5700.
Resolved by #5704
src/test/obj_sync/TEST5
line 19 at r1 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
See #5700.
Resolved by #5704
src/test/obj_sync/TEST6
line 19 at r1 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
See #5700.
Resolved by #5704
src/test/pmem2_map_prot/TESTS.py
line 75 at r1 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
It seems that #5599 has already been fixed.
Let's keep it as it is in 1.13.1.
We will check/fix it in 1.14.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐐
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @janekmi)
dfbacb9
to
a8c0a7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 50 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), 5 unresolved discussions (waiting on @grom72)
ChangeLog
line 18 at r1 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
Resolved by #5703
Done.
ChangeLog
line 21 at r1 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
Resolved by #5703
Done.
src/test/pmem2_integration/TESTS.py
line 3 at r1 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
No changes in this file.
It is not a squashed commit merge. All commits present on the stable-1.13 branch that is missing on the master branch are merged with this commit. The history of this file on stable-1.13 proves it was modified. Even if all the changes zeroed in at the end of the day.
Ref: https://github.com/pmem/pmdk/commits/stable-1.13/src/test/pmem2_integration/TESTS.py
src/test/pmem2_map_from_existing/TESTS.py
line 3 at r1 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
No changes in this file
Ref: https://github.com/pmem/pmdk/commits/stable-1.13/src/test/pmem2_map_from_existing/TESTS.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @grom72 and @janekmi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @janekmi)
test: disable obj_sync/TEST[2,5-6] for all configurations until pmem#5646 is fixed
common: 1.13.1 release
a8c0a7b
to
8203069
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @janekmi)
This change is