fix: gocognit on publish block and fixing publish blinded block header check #14913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
added
Bug
james-prysm
requested review from
prestonvanloon and
rkapka
and removed request for
dB2510
james-prysm
changed the title
rkapka
reviewed
Feb 11, 2025
| writer.Body = &bytes.Buffer{} | ||
| server.PublishBlindedBlock(writer, request) | ||
| assert.Equal(t, http.StatusBadRequest, writer.Code) | ||
| assert.StringContains(t, fmt.Sprintf("could not decode request body into %s consensus block", version.String(version.Phase0)), writer.Body.String()) |
There was a problem hiding this comment.
Can you either add a comment why the error string should contain version.Phase0 or change the test name to "Blinded Electra block without version header on Phase0 fork"?
rkapka
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
a continuation of #14897 that fixes the publish blinded block endpoints and re-factors the code to remove the gocognit error as well as easier handling of future hard fork types.
note this PR is required to fix electra setups with a validator running in REST mode with mevboost.
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements