Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single attestation cleanup #14984

Merged
merged 16 commits into from
Mar 4, 2025
+87 −70
Merged

single attestation cleanup #14984

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
25fafbb
some cleanup and minor bug fix
james-prysm Feb 25, 2025
fee5dc3
adding some comments back in
james-prysm Feb 25, 2025
b91d11c
Update beacon-chain/sync/pending_attestations_queue.go
james-prysm Feb 25, 2025
dc84188
Update beacon-chain/sync/pending_attestations_queue.go
james-prysm Feb 25, 2025
a6ef778
Update beacon-chain/sync/validate_beacon_attestation.go
james-prysm Feb 25, 2025
8062dbb
Update beacon-chain/sync/validate_beacon_attestation.go
james-prysm Feb 25, 2025
e8ebdf3
Update beacon-chain/sync/validate_beacon_attestation.go
james-prysm Feb 25, 2025
f1e15fa
Update beacon-chain/sync/validate_beacon_attestation.go
james-prysm Feb 25, 2025
c44fc6a
Update beacon-chain/sync/validate_beacon_attestation.go
james-prysm Feb 25, 2025
cc7e16e
Update beacon-chain/sync/pending_attestations_queue.go
james-prysm Feb 25, 2025
dda6232
adding comment back in
james-prysm Feb 25, 2025
3be80b0
linting
james-prysm Feb 25, 2025
449b24b
fixing committeeIndiciesSLot
james-prysm Feb 27, 2025
ebc95fb
Merge branch 'develop' into attestation-cleanup-suggestions
james-prysm Feb 28, 2025
f115f7c
Merge branch 'develop' into attestation-cleanup-suggestions
james-prysm Mar 3, 2025
c47b448
fixing changelog
james-prysm Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
Update beacon-chain/sync/validate_beacon_attestation.go 
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
@james-prysm @rkapka
james-prysm and rkapka authored Feb 25, 2025

Verified

This commit was created on github.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit a6ef778b1b00d7bff7a7acb38fd005d4fe3adfd8
2 changes: 1 addition & 1 deletion beacon-chain/sync/validate_beacon_attestation.go
View file
Original file line number Diff line number Diff line change
@@ -152,7 +152,7 @@ func (s *Service) validateCommitteeIndexBeaconAttestation(
&eth.SingleAttestation{}, att,
)
}
// Convert Electra singleAttestation to the unaggregated form needed for local validation
// Convert Electra SingleAttestation to unaggregated ElectraAttestation. This is needed because many parts of the codebase assume that attestations have a certain structure and SingleAttestation validates these assumptions.
attForValidation = singleAtt.ToAttestationElectra(committee)
eventType = operation.SingleAttReceived
eventData = &operation.SingleAttReceivedData{