single attestation cleanup #14984
Merged
single attestation cleanup #14984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
commented
Feb 25, 2025
| // Verify the block being voted and the processed state is in beaconDB and the block has passed validation if it's in the beaconDB. | ||
| blockRoot := bytesutil.ToBytes32(data.BeaconBlockRoot) | ||
| if !s.hasBlockAndState(ctx, blockRoot) { | ||
| return s.saveToPendingAttPool(att) | ||
| } | ||
|
|
||
| if !s.cfg.chain.InForkchoice(bytesutil.ToBytes32(data.BeaconBlockRoot)) { | ||
| if !s.cfg.chain.InForkchoice(blockRoot) { |
There was a problem hiding this comment.
I think we can just use blockRoot here, because it's already calculated above
james-prysm
commented
Feb 25, 2025
| if validationRes != pubsub.ValidationAccept { | ||
| return validationRes, err | ||
| } | ||
|
|
||
| committee, err := helpers.BeaconCommitteeFromState(ctx, preState, att.GetData().Slot, committeeIndex) | ||
| committee, err := helpers.BeaconCommitteeFromState(ctx, preState, data.Slot, committeeIndex) |
There was a problem hiding this comment.
we don't need to get data again, we already have data
rkapka
reviewed
Feb 25, 2025
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
rkapka
previously approved these changes
Feb 26, 2025
james-prysm
dismissed
rkapka’s stale review
will break out the fix and add unit test for it
james-prysm
commented
Feb 27, 2025
| log.WithError(err).Debug("Could not save unaggregated attestation") | ||
| return | ||
| } | ||
| } | ||
| s.setSeenCommitteeIndicesSlot(data.Slot, data.CommitteeIndex, att.GetAggregationBits()) | ||
| s.setSeenCommitteeIndicesSlot(data.Slot, data.GetCommitteeIndex(), attForValidation.GetAggregationBits()) |
There was a problem hiding this comment.
dang this is still wrong pr fixes this #14998
james-prysm
changed the title
rkapka
approved these changes
Mar 4, 2025
rkapka
added a commit
that referenced
this pull request
Mar 19, 2025
* some cleanup and minor bug fix * adding some comments back in * Update beacon-chain/sync/pending_attestations_queue.go Co-authored-by: Radosław Kapka <rkapka@wp.pl> * Update beacon-chain/sync/pending_attestations_queue.go Co-authored-by: Radosław Kapka <rkapka@wp.pl> * Update beacon-chain/sync/validate_beacon_attestation.go Co-authored-by: Radosław Kapka <rkapka@wp.pl> * Update beacon-chain/sync/validate_beacon_attestation.go Co-authored-by: Radosław Kapka <rkapka@wp.pl> * Update beacon-chain/sync/validate_beacon_attestation.go Co-authored-by: Radosław Kapka <rkapka@wp.pl> * Update beacon-chain/sync/validate_beacon_attestation.go Co-authored-by: Radosław Kapka <rkapka@wp.pl> * Update beacon-chain/sync/validate_beacon_attestation.go Co-authored-by: Radosław Kapka <rkapka@wp.pl> * Update beacon-chain/sync/pending_attestations_queue.go Co-authored-by: Radosław Kapka <rkapka@wp.pl> * adding comment back in * linting * fixing committeeIndiciesSLot * fixing changelog --------- Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
This PR does some minor cleanup to reduce cognitive load when reading what should be a single attestation vs regular attestation
kurtosis run with devnet 6 settings 3 nodes ( teku/nethermind, 2x prysm/geth)
attestation events still working
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements