Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache uses wrong seen committee index for electra #14998

Merged
merged 5 commits into from
Mar 3, 2025

Conversation

james-prysm
Copy link
Contributor

@james-prysm james-prysm commented Feb 27, 2025

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

PR fixes a small bug with using the wrong committee index for electra attestations. adds some unit tests as well.

Which issues(s) does this PR fix?

Fixes #

Other notes for review

Acknowledgements

@james-prysm james-prysm added Bug Something isn't working Electra electra hardfork labels Feb 27, 2025
@james-prysm james-prysm requested a review from a team as a code owner February 27, 2025 21:34
@james-prysm james-prysm mentioned this pull request Feb 27, 2025
3 tasks
nisdas
nisdas previously approved these changes Feb 28, 2025
Copy link
Contributor

@rkapka rkapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass with the old code, so they are not actually testing anything

@james-prysm james-prysm enabled auto-merge March 3, 2025 16:24
@james-prysm james-prysm added this pull request to the merge queue Mar 3, 2025
Merged via the queue into develop with commit 6e00db4 Mar 3, 2025
16 checks passed
@james-prysm james-prysm deleted the fix-wrong-committee-seen branch March 3, 2025 17:01
rkapka pushed a commit that referenced this pull request Mar 19, 2025
* adding fix and unit tests

* removing unneeded test for now, will handle in separate PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Electra electra hardfork
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants