Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Add" solutions from different models #1276

Closed
valentinsulzer opened this issue Dec 5, 2020 · 0 comments · Fixed by #1408
Closed

"Add" solutions from different models #1276

valentinsulzer opened this issue Dec 5, 2020 · 0 comments · Fixed by #1408
Assignees
@valentinsulzer

Comments

@valentinsulzer
Copy link
Member

Add functionality to "add" (i.e. concatenate) solutions that come from different models, e.g. using a DFN for the charge and a SPM for the discharge.
@valentinsulzer valentinsulzer self-assigned this Dec 24, 2020
@valentinsulzer valentinsulzer mentioned this issue Jan 18, 2021
Closed
valentinsulzer added a commit that referenced this issue Feb 27, 2021
@valentinsulzer
#1276 reformat solution with experiment
349ce68
valentinsulzer added a commit that referenced this issue Feb 27, 2021
@valentinsulzer
#1276 reformat solution to allow several models
b48f8ca
valentinsulzer added a commit that referenced this issue Feb 27, 2021
@valentinsulzer
#1276 new simulation of experiment working for gitt
c47da0d
valentinsulzer added a commit that referenced this issue Feb 27, 2021
@valentinsulzer
#1276 adding other experiment types
2c2651e
valentinsulzer added a commit that referenced this issue Feb 27, 2021
@valentinsulzer
#1276 testing discretize-then-parameterize
62f3ab6
valentinsulzer added a commit that referenced this issue Feb 27, 2021
@valentinsulzer
#1276 testing new simulation
81be0e0
valentinsulzer added a commit that referenced this issue Feb 27, 2021
@valentinsulzer
#1276 some optimizations
bf0d441
valentinsulzer added a commit that referenced this issue Feb 27, 2021
@valentinsulzer
#1276 merge EC SEI branch
daa51d7
valentinsulzer added a commit that referenced this issue Mar 1, 2021
@valentinsulzer
#1276 flake8
89cb284
@valentinsulzer valentinsulzer mentioned this issue Mar 1, 2021
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Mar 1, 2021
@valentinsulzer
#1276 fixing tests
ded4daf
valentinsulzer added a commit that referenced this issue Mar 1, 2021
@valentinsulzer
#1276 coverage
d5035a6
valentinsulzer added a commit that referenced this issue Mar 1, 2021
@valentinsulzer
#1276 coverage
6de9a13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 1276 add models pybamm-team/PyBaMM
1 participant
@valentinsulzer