Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor Simulation class #39

Closed
valentinsulzer opened this issue Dec 20, 2018 · 2 comments
Closed

refactor Simulation class #39

valentinsulzer opened this issue Dec 20, 2018 · 2 comments
Assignees

Comments

@valentinsulzer
Copy link
Member

Refactor Simulation class to run the whole process (create model, set parameters, discretise, solve, visualise). Needs to take optional inputs for the parameter class, parameter file, mesh/discretisation, solver, and set defaults if these are None. Can later add capability to save solution, load a saved solution, etc.

class Simulation(object):
   def __init__(
        self,
        model,
        parameter_values=None,
        discretisation=None,
        solver=None,
        name="unnamed",
    ):
        # Defaults
        if parameter_values is None:
           # default parameter_values
        if discretisation is None:
           # default discretisation
        if solver is None:
            # default solver

        self.model = model
        self.parameter_values = parameter_values
        self.discretisation = discretisation
        self.solver = solver
        self.name = name

    def set_parameters(self):
        self.parameter_values.process(self.model)

    def discretise(self):
        y0 = self.discretisation.process(self.model)
        return y0

    def solve(self, y0):
        self.solver.solve(self.model, y0)

    def run(self):
        self.set_parameters()
        y0 = self.discretise()
        self.solve(y0)

    def load(self):

    def save(self):

    def plot(self):
@valentinsulzer
Copy link
Member Author

re-opening following discussions in meetings

valentinsulzer added a commit that referenced this issue Oct 26, 2019
valentinsulzer added a commit that referenced this issue Oct 26, 2019
@valentinsulzer
Copy link
Member Author

Now in #688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant