Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simulation class #688

Closed
Scottmar93 opened this issue Oct 26, 2019 · 3 comments · Fixed by #693
Closed

Add simulation class #688

Scottmar93 opened this issue Oct 26, 2019 · 3 comments · Fixed by #693
Assignees

Comments

@Scottmar93
Copy link
Contributor

Summary
Create a simulation class which wraps model, discretization, parameters etc.

Motivation
Can be extended to allow linking of the experiment, model, discretization, and solver together and allow each to reference each other. Also simplifies the pybamm user interface so that users only need to see what the actually are setting

@Scottmar93 Scottmar93 self-assigned this Oct 26, 2019
@valentinsulzer
Copy link
Member

See #39 and the branch issue-39-simulation-class - happy for you to take over on this though :)

@Scottmar93
Copy link
Contributor Author

Ah nice thought you had deleted the branch so just made a quick mock up of what the class would look like. Will take a look at #39 as well. Doesn't seem like there is too much to do but might be nice to have some reset type features that would allow you to undiscretize your model etc.

@valentinsulzer
Copy link
Member

Sounds good, note you can do disc.process_model(model, inplace=False) to leave the original model un-discretised

Scottmar93 added a commit that referenced this issue Oct 30, 2019
Scottmar93 added a commit that referenced this issue Oct 30, 2019
Scottmar93 added a commit that referenced this issue Oct 30, 2019
Scottmar93 added a commit that referenced this issue Oct 30, 2019
Scottmar93 added a commit that referenced this issue Oct 30, 2019
Scottmar93 added a commit that referenced this issue Oct 31, 2019
Scottmar93 added a commit that referenced this issue Oct 31, 2019
Scottmar93 added a commit that referenced this issue Oct 31, 2019
Scottmar93 added a commit that referenced this issue Oct 31, 2019
Scottmar93 added a commit that referenced this issue Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants