-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simulation class #688
Comments
See #39 and the branch |
Ah nice thought you had deleted the branch so just made a quick mock up of what the class would look like. Will take a look at #39 as well. Doesn't seem like there is too much to do but might be nice to have some reset type features that would allow you to undiscretize your model etc. |
Sounds good, note you can do |
Summary
Create a simulation class which wraps model, discretization, parameters etc.
Motivation
Can be extended to allow linking of the experiment, model, discretization, and solver together and allow each to reference each other. Also simplifies the pybamm user interface so that users only need to see what the actually are setting
The text was updated successfully, but these errors were encountered: