Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove python-Levenshtein dependency #833

Closed
valentinsulzer opened this issue Feb 17, 2020 · 0 comments · Fixed by #847
Closed

Remove python-Levenshtein dependency #833

valentinsulzer opened this issue Feb 17, 2020 · 0 comments · Fixed by #847
Assignees
@valentinsulzer

Comments

@valentinsulzer
Copy link
Member

valentinsulzer commented Feb 17, 2020 •
edited
Loading

Manually implement the levenshtein distance calculation to remove this dependency (it isn't very important anyway and only appears in FuzzyDict). Efficiency of the levenshtein distance calculator really doesn't matter as it is only used to give a more informative error message (i.e. won't be used in normal operation)

Formula for levenshtein distance
@valentinsulzer valentinsulzer self-assigned this Feb 21, 2020
valentinsulzer added a commit that referenced this issue Feb 21, 2020
@valentinsulzer
#833 manual implementation of levenshtein
7652c7f
@valentinsulzer valentinsulzer mentioned this issue Feb 21, 2020
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Feb 21, 2020
@valentinsulzer
#833 make fewer calls to levenshtein ratio
7818826
valentinsulzer added a commit that referenced this issue Feb 21, 2020
@valentinsulzer
#833 flake8
e4b4113
valentinsulzer added a commit that referenced this issue Feb 25, 2020
@valentinsulzer
Merge pull request #847 from pybamm-team/issue-833-levenshtein
5431255 
#833 manual implementation of levenshtein
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#833 manual implementation of levenshtein pybamm-team/PyBaMM
1 participant
@valentinsulzer