Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#833 manual implementation of levenshtein #847

Merged
merged 3 commits into from
Feb 25, 2020

Conversation

valentinsulzer
Copy link
Member

Description

Removes dependency that was causing problems

Fixes #833

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #847 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #847    +/-   ##
========================================
  Coverage   98.24%   98.25%            
========================================
  Files         180      180            
  Lines       10254    10519   +265     
========================================
+ Hits        10074    10335   +261     
- Misses        180      184     +4     
Impacted Files Coverage Δ
pybamm/util.py 97.34% <0.00%> (-2.66%) ⬇️
...odels/full_battery_models/lithium_ion/basic_dfn.py 100.00% <0.00%> (ø) ⬆️
...odels/full_battery_models/lithium_ion/basic_spm.py 100.00% <0.00%> (ø) ⬆️
pybamm/solvers/base_solver.py 99.44% <0.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53fa5f5...e4b4113. Read the comment docs.

Copy link
Contributor

@tlestang tlestang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@valentinsulzer valentinsulzer merged commit 5431255 into master Feb 25, 2020
@valentinsulzer valentinsulzer deleted the issue-833-levenshtein branch February 25, 2020 13:52
rtimms added a commit that referenced this pull request Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove python-Levenshtein dependency
2 participants