-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1127 extra notebooks #1131
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1131 +/- ##
========================================
Coverage 97.92% 97.92%
========================================
Files 247 247
Lines 13910 13911 +1
========================================
+ Hits 13622 13623 +1
Misses 288 288
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two minor comments but looks good to me. Thanks Rob!
examples/notebooks/README.md
Outdated
@@ -13,7 +13,7 @@ These notebooks can be downloaded and used locally by running | |||
``` | |||
$ jupyter notebook | |||
``` | |||
from your local PyBaMM repository, or used online through [Binder](https://mybinder.org/v2/gh/pybamm-team/PyBaMM/master), or you can simply copy/paste the relevant code. | |||
from your local PyBaMM repository, or used online through [Google Colab](https://colab.research.google.com/github/pybamm-team/PyBaMM/blob/master/) or [Binder](https://mybinder.org/v2/gh/pybamm-team/PyBaMM/master). Alternatively, you can simply copy/paste the relevant code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we using Binder? I removed it because I thought we weren't but happy to keep it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed it. I think the link still works, but Colab is better
"source": [ | ||
"# Tutorial 9 - Changing the mesh\n", | ||
"\n", | ||
"In [Tutorial 8](./Tutorial%207%20-%20Solver%20options.ipynb) we saw how to change the solver options. In this tutorial we will change the mesh used in the simulation, and, as in the solver options tutorial, show how to do a graphical mesh refinement study.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the end we didn't show how to do a graphical convergence study so we should change this sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I've updated this
Description
Fixes some of #1127
Leaving #1127 open as I still think we should add details of the DFN in dimensional form and add a table or similar giving the string names for the parameters (at least for the basic DFN).
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: