Drive Cycle in Experiment

[alibh95]

Description

Added the functionality to simulate drive cycle using the experiment class.

Fixes # (issue)
#1193
#1265

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• [✓] New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• [✓] No style issues: $ flake8
• All tests pass: $ python run-tests.py --unit
• The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

• [✓] Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

Merging #1279 (a4dc137) into develop (9d42dfe) will decrease coverage by 0.21%.
The diff coverage is 47.61%.

@@             Coverage Diff             @@
##           develop    #1279      +/-   ##
===========================================
- Coverage    98.07%   97.86%   -0.22%     
===========================================
  Files          270      270              
  Lines        15030    15065      +35     
===========================================
+ Hits         14741    14743       +2     
- Misses         289      322      +33     

Impacted Files	Coverage Δ
pybamm/simulation.py	85.94% <47.16%> (-10.88%)	⬇️
pybamm/experiments/experiment.py	93.96% <50.00%> (-4.22%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d42dfe...2ff283c. Read the comment docs.

[valentinsulzer]

@alibh95 , thanks very much for taking this on!

Can you add tests for the changes you have made?
After we merge #1278 , there will be a way to do this in a more efficient way, but this is a good first step.

[valentinsulzer]

drive cycles should still (optionally) allow for events

[valentinsulzer]

@alibh95 I have an idea for how to do this slightly differently. Are you still working on it?

[alibh95]

@tinosulzer Yes, I am working on this issue. Till now I am able to add the functionality of "for event" but unable to add the functionality of "until event".