Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark legacy modifier keys and codes as deprecated #49

Merged
merged 1 commit into from
Mar 23, 2025
Merged

Mark legacy modifier keys and codes as deprecated #49

merged 1 commit into from
Mar 23, 2025

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Dec 1, 2024 •
edited
Loading

This resolves my concern with Meta vs. Super from #19.

@pyfisch
Copy link
Owner

pyfisch commented Dec 22, 2024

Please rebase the PR.

@madsmtm
Copy link
Contributor Author

madsmtm commented Feb 13, 2025

Rebased now.

@madsmtm madsmtm marked this pull request as ready for review February 13, 2025 17:11
@madsmtm
Copy link
Contributor Author

madsmtm commented Mar 7, 2025

Weird, KeyCode::Cut, KeyCode::Find, etc. seems like they're actually emitted by Winit?
TODO: What does Chrome/Firefox emit on Web if you click these keys?

@madsmtm madsmtm mentioned this pull request Mar 7, 2025
Merged
4 tasks
@madsmtm madsmtm changed the title Mark legacy keys and codes as deprecated Mark legacy modifier keys and codes as deprecated Mar 10, 2025
@madsmtm
Copy link
Contributor Author

madsmtm commented Mar 10, 2025 •
edited
Loading

Weird, KeyCode::Cut, KeyCode::Find, etc. seems like they're actually emitted by Winit?
TODO: What does Chrome/Firefox emit on Web if you click these keys?

Looking at Chromium's source code, it's clear that they do emit these key codes. So I've un-marked them as deprecated for now, and made this PR only focus on the deprecated modifier keys (since that will be confusing when upgrading Winit).

@madsmtm madsmtm mentioned this pull request Mar 10, 2025
Closed
9 tasks
@madsmtm madsmtm mentioned this pull request Mar 10, 2025
Open
@pyfisch pyfisch merged commit 4565361 into pyfisch:main Mar 23, 2025
3 checks passed
@madsmtm madsmtm deleted the deprecated branch March 23, 2025 11:09
@madsmtm madsmtm mentioned this pull request Mar 23, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madsmtm @pyfisch