WIP: Use keyboard-types
#4026
Draft
WIP: Use keyboard-types
#4026
+53
−1,891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
S - enhancement
4 tasks
|
Looking forward to seeing this merged! Currently Blitz is using some custom code to convert between Winit events and keyboard_type events. I expect to do the same thing in Masonry. |
9 tasks
madsmtm
force-pushed
the
madsmtm/keyboard-types
branch
3 times, most recently
from
53dce06 to
d2c4d1b
Compare
madsmtm
commented
Mar 23, 2025
| @@ -79,6 +86,7 @@ cfg_aliases = "0.2.1" | |||
| bitflags = "2" | |||
| cursor-icon = "1.1.0" | |||
| dpi = { version = "0.1.1", path = "dpi" } | |||
| keyboard-types = { git = "https://github.com/pyfisch/keyboard-types.git", branch = "main" } | |||
There was a problem hiding this comment.
This PR is now ready to be reviewed, though note that v0.8 isn't released yet, so we shouldn't merge it before it is.
There was a problem hiding this comment.
Yeah, we certainly should, so I've converted to draft for now.
madsmtm
force-pushed
the
madsmtm/keyboard-types
branch
from
848ffc1 to
02d3456
Compare
kchibisov
approved these changes
Mar 23, 2025
Yup, I didn't deprecate those in pyfisch/keyboard-types#49. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use and re-export
keyboard_types::NamedKey,keyboard_types::Codeandkeyboard_types::Locationfrom thekeyboard-typescrate.Unsure what the best way to re-export these is, we might for example want
#[doc(inline)]?I haven't used
keyboard_types::Modifiersyet, since that has a differentserdeimplementation, which is kind of an ABI break and might be hard for downstream to handle, see #4018 (comment).Part of #2394. See also pyfisch/keyboard-types#60.