Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix StarConnectivtyPlacer/Router._check_star_connectivity for len(nodes)>5 #1567

Merged
merged 9 commits into from
Jan 28, 2025
Merged

Fix StarConnectivtyPlacer/Router._check_star_connectivity for len(nodes)>5 #1567

merged 9 commits into from
Jan 28, 2025

Conversation

GuillermoAbadLopez
Copy link
Contributor

@GuillermoAbadLopez GuillermoAbadLopez commented Jan 26, 2025 •
edited by renatomello
Loading

Tackles Issue: #1566

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@GuillermoAbadLopez GuillermoAbadLopez mentioned this pull request Jan 26, 2025
Closed
@renatomello renatomello added the bug Something isn't working label Jan 28, 2025
@renatomello renatomello added this to the Qibo 0.2.16 milestone Jan 28, 2025
@renatomello renatomello linked an issue Jan 28, 2025 that may be closed by this pull request
StarConnectivtyPlacer/Router._check_star_connectivity not raising error for len(nodes)>5 #1566
Closed
@GuillermoAbadLopez @renatomello
Apply suggestions from code review
0d5db8b 
Co-authored-by: Renato Mello <renato.msf@gmail.com>
@renatomello renatomello added this pull request to the merge queue Jan 28, 2025
Merged via the queue into qiboteam:master with commit e7d93e6 Jan 28, 2025
1 check passed
@GuillermoAbadLopez GuillermoAbadLopez deleted the fix_is_star_connectivity branch January 28, 2025 15:08
@renatomello renatomello mentioned this pull request Jan 29, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatomello renatomello renatomello approved these changes

@alecandido alecandido alecandido approved these changes

Assignees

@GuillermoAbadLopez GuillermoAbadLopez

Labels
bug Something isn't working
Projects
None yet
Milestone
Qibo 0.2.16
Development

Successfully merging this pull request may close these issues.

StarConnectivtyPlacer/Router._check_star_connectivity not raising error for len(nodes)>5
3 participants
@GuillermoAbadLopez @renatomello @alecandido