Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StarConnectivtyPlacer/Router._check_star_connectivity for len(nodes)>5 #1567

Merged
merged 9 commits into from
Jan 28, 2025
Merged

Fix StarConnectivtyPlacer/Router._check_star_connectivity for len(nodes)>5 #1567

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0477599
fix is_star_connectivity check
GuillermoAbadLopez Jan 26, 2025
2f96fb6
typo on StarConnectivity length
GuillermoAbadLopez Jan 27, 2025
6acd1cf
typo on StarConnectivity length
GuillermoAbadLopez Jan 27, 2025
7731476
Specify type of Error in check_star_connectivity, solve typo, and add…
GuillermoAbadLopez Jan 27, 2025
22afc5c
Adding spaces for precommit
GuillermoAbadLopez Jan 27, 2025
a6b6989
Solving code-quality checks
GuillermoAbadLopez Jan 27, 2025
ece1cc7
solving black checks
GuillermoAbadLopez Jan 27, 2025
66e9f81
black checks
GuillermoAbadLopez Jan 27, 2025
0d5db8b
Apply suggestions from code review
GuillermoAbadLopez Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/qibo/transpiler/placer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,18 @@ def __call__(self, circuit: Circuit):

def _check_star_connectivity(self):
"""Check if the connectivity graph is a star graph."""
if len(self.connectivity.node) != 5:
raise_error(
ValueError,
f"This connectivity graph is not a star graph. Length of nodes provided: {self.connectivity.node} != 5.",
)
for node in self.connectivity.nodes:
if self.connectivity.degree(node) == 4:
self.middle_qubit = node
elif self.connectivity.degree(node) != 1:
raise_error(
ValueError,
"This connectivity graph is not a star graph.",
"This connectivity graph is not a star graph. There is a node with degree different from 1 or 4.",
)


Expand Down
7 changes: 6 additions & 1 deletion src/qibo/transpiler/router.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,13 +91,18 @@ def __call__(self, circuit: Circuit):

def _check_star_connectivity(self):
"""Check if the connectivity graph is a star graph."""
if len(self.connectivity.node) != 5:
raise_error(
ValueError,
f"This connectivity graph is not a star graph. Length of nodes provided: {self.connectivity.node} != 5.",
)
for node in self.connectivity.nodes:
if self.connectivity.degree(node) == 4:
self.middle_qubit = node
elif self.connectivity.degree(node) != 1:
raise_error(
ValueError,
"This connectivity graph is not a star graph.",
"This connectivity graph is not a star graph. There is a node with degree different from 1 or 4.",
)


Expand Down