Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate the sweetspot closest to the center of bias interval #1068

Merged
merged 8 commits into from
Jan 24, 2025

Conversation

Edoardo-Pedicillo
Copy link
Contributor

@Edoardo-Pedicillo Edoardo-Pedicillo commented Jan 23, 2025

This PR solves #1067 and improves the documentation for qubit flux dependency.

By re-executing the fit of the report in the issue, this is the final result http://login.qrccluster.com:9000/nR6UbuqNQB2FTe7hRsI2Ww==/

EDIT: updated version with the sweetspot plot http://login.qrccluster.com:9000/E8Q42n_PRhyPS3WZbCLDVg==/

@Edoardo-Pedicillo Edoardo-Pedicillo added this to the Qibocal 0.1.2 milestone Jan 23, 2025
@Edoardo-Pedicillo Edoardo-Pedicillo changed the title fix: evaluate the sweetspot closest to the center of the swept freque… evaluate the sweetspot closest to the center of the swept freque… Jan 23, 2025
@Edoardo-Pedicillo Edoardo-Pedicillo changed the title evaluate the sweetspot closest to the center of the swept freque… Evaluate the sweetspot closest to the center of the swept freque… Jan 23, 2025
@Edoardo-Pedicillo Edoardo-Pedicillo changed the title Evaluate the sweetspot closest to the center of the swept freque… Evaluate the sweetspot closest to the center of bias interval Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.32%. Comparing base (78a0bbb) to head (8f21d94).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1068   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files         124      124           
  Lines        9894     9896    +2     
=======================================
+ Hits         9629     9631    +2     
  Misses        265      265           
Flag Coverage Δ
unittests 97.32% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...protocols/flux_dependence/qubit_flux_dependence.py 97.39% <100.00%> (+0.02%) ⬆️
...l/protocols/flux_dependence/resonator_crosstalk.py 96.89% <ø> (ø)
...ocols/flux_dependence/resonator_flux_dependence.py 98.31% <100.00%> (ø)
src/qibocal/protocols/flux_dependence/utils.py 98.96% <100.00%> (+0.01%) ⬆️

... and 3 files with indirect coverage changes

Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fig.add_trace(
go.Scatter(
x=[
fit.frequency[qubit] * HZ_TO_GHZ,
Copy link
Contributor

@andrea-pasquale andrea-pasquale Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The corresponding attribute for resonator flux dependence is resonator_freq.
Either we change the name of the attribute in the corresponding resonator class or we need to add an if statement here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the first option, since having a resonator_freq attribute in ResonatoFluxResults is a bit redundant.

@Edoardo-Pedicillo Edoardo-Pedicillo added this pull request to the merge queue Jan 24, 2025
Merged via the queue into main with commit 0b4711b Jan 24, 2025
21 checks passed
@Edoardo-Pedicillo Edoardo-Pedicillo deleted the sweetspot branch January 24, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants