-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluate the sweetspot closest to the center of bias interval #1068
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1068 +/- ##
=======================================
Coverage 97.32% 97.32%
=======================================
Files 124 124
Lines 9894 9896 +2
=======================================
+ Hits 9629 9631 +2
Misses 265 265
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Edoardo-Pedicillo
fig.add_trace( | ||
go.Scatter( | ||
x=[ | ||
fit.frequency[qubit] * HZ_TO_GHZ, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The corresponding attribute for resonator flux dependence is resonator_freq
.
Either we change the name of the attribute in the corresponding resonator class or we need to add an if statement here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the first option, since having a resonator_freq
attribute in ResonatoFluxResults
is a bit redundant.
This PR solves #1067 and improves the documentation for qubit flux dependency.
By re-executing the fit of the report in the issue, this is the final result http://login.qrccluster.com:9000/nR6UbuqNQB2FTe7hRsI2Ww==/
EDIT: updated version with the sweetspot plot http://login.qrccluster.com:9000/E8Q42n_PRhyPS3WZbCLDVg==/