-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluate the sweetspot closest to the center of bias interval #1068
Merged
+67
−36
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
12bcfea
fix: evaluate the sweetspot closest to the center of the swept freque…
Edoardo-Pedicillo a23d7ae
fix: mismatch freq and biases
Edoardo-Pedicillo 051abd5
doc: improve documentation of qubit flux dependency fit
Edoardo-Pedicillo 0f4b58c
refactor: change method to evaluate middle point
Edoardo-Pedicillo 79b0cf4
fix: remove variables overwrite
Edoardo-Pedicillo bce5dfb
feat: plot sweetspot
Edoardo-Pedicillo dd0339f
fix: rename attribute in Resonator Flux dependence results
Edoardo-Pedicillo 8f21d94
Merge branch 'sweetspot' of github.com:qiboteam/qibocal into sweetspot
Edoardo-Pedicillo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat: plot sweetspot
commit bce5dfb9881ed39e8ec0d27395c80569baa51d43
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The corresponding attribute for resonator flux dependence is
resonator_freq
.Either we change the name of the attribute in the corresponding resonator class or we need to add an if statement here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the first option, since having a
resonator_freq
attribute inResonatoFluxResults
is a bit redundant.