-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new device factor source #380
Merged
Merged
Changes from 26 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
acce421
Initial setup new factor adding builder
sergiupuhalschi-rdx a79d8cd
WIP
sergiupuhalschi-rdx fb37f0b
Uniffi export
sergiupuhalschi-rdx 8661ecb
WIP
sergiupuhalschi-rdx 3e5616d
WIP
sergiupuhalschi-rdx 1f0097b
WIP
sergiupuhalschi-rdx 73b1483
Merge branch 'main' into sp/add-new-factor-builder
sergiupuhalschi-rdx 32a32f1
PR comments
sergiupuhalschi-rdx dab1d1c
Address comments
sergiupuhalschi-rdx 7d76099
Merge branch 'main' into sp/add-new-factor-builder
sergiupuhalschi-rdx 284abe8
WIP
sergiupuhalschi-rdx 93bb0ec
WIP
sergiupuhalschi-rdx c59b561
WIP
sergiupuhalschi-rdx 4a9113b
Merge main
sergiupuhalschi-rdx aa0e36a
WIP
sergiupuhalschi-rdx 6bebee0
Remove unnecessary test
sergiupuhalschi-rdx 6e92c10
WIP
sergiupuhalschi-rdx ea6d363
Add tests
sergiupuhalschi-rdx 7efc3b8
Add tests
sergiupuhalschi-rdx 5d12b26
Add test
sergiupuhalschi-rdx 3edd3e1
Fix fn cfg
sergiupuhalschi-rdx a3232f6
Fix typo
sergiupuhalschi-rdx 14fab67
Expose function
sergiupuhalschi-rdx 32cc180
PR review
sergiupuhalschi-rdx c1272b4
Expose error
sergiupuhalschi-rdx e6af3bd
Improve random indices generating
sergiupuhalschi-rdx cdf3635
PR review
sergiupuhalschi-rdx 55cc10e
PR review
sergiupuhalschi-rdx 1660d38
Release 1.2.2
sergiupuhalschi-rdx 9ad682b
Review comments
sergiupuhalschi-rdx 5ca9092
Review comments
sergiupuhalschi-rdx 9df9ba4
Improve API
sergiupuhalschi-rdx 7e9c279
Improve API
sergiupuhalschi-rdx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is mostly constrained by mnemonic_with_passphrase, so I would add an its name the mention of MWP, to know this applies only to the kinds of factor sources which have their id derived from MWP.