Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RM] Add error handling for missing plugin tags in URDF parsing (backport #2138) #2145

Merged
merged 2 commits into from
Mar 28, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 28, 2025

Added a try-catch block statement to check the validity of type_it in hardware interface parser. It returns an error signifying the missing plugin in either hardware or transmission element


This is an automatic backport of pull request #2138 done by Mergify.

)

(cherry picked from commit c4aca5f)

# Conflicts:
#	hardware_interface/src/component_parser.cpp
Copy link
Contributor Author

mergify bot commented Mar 28, 2025

Cherry-pick of c4aca5f has failed:

On branch mergify/bp/humble/pr-2138
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit c4aca5f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   hardware_interface/src/component_parser.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Mar 28, 2025
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.53%. Comparing base (a978e78) to head (49702ad).
Report is 1 commits behind head on humble.

Files with missing lines Patch % Lines
hardware_interface/src/component_parser.cpp 0.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #2145      +/-   ##
==========================================
- Coverage   63.58%   63.53%   -0.05%     
==========================================
  Files         112      112              
  Lines       12848    12852       +4     
  Branches     8662     8661       -1     
==========================================
- Hits         8169     8166       -3     
- Misses        790      794       +4     
- Partials     3889     3892       +3     
Flag Coverage Δ
unittests 63.53% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
hardware_interface/src/component_parser.cpp 90.33% <0.00%> (-1.55%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit 63204a6 into humble Mar 28, 2025
12 of 13 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-2138 branch March 28, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants