-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: adding videos to CI report artifact #8990
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
No changes to documentation |
Coverage Report
File CoverageNo changed files found. |
⚡️ Editor Performance ReportUpdated Thu, 20 Mar 2025 15:40:18 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
📊 Playwright Test ReportThis report contains test results, including videos of failing tests. |
… report
5f62b78
to
5a5f1b7
Compare
echo "url=$URL" >> $GITHUB_OUTPUT | ||
|
||
- name: Add PR Comment with Report Link | ||
uses: thollander/actions-comment-pull-request@fabd468d3a1a0b97feee5f6b9e499eab0dd903f6 # v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is roughly the same step that was used when we created a GH PR comment for the playwright component tests - which can be seen here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you @jordanl17 !
* next: (81 commits) fix(presentation): use `perspectiveStack` when resolving main document (#9005) fix(core): hide discard changes action when published (#9009) fix(sanity): treat releases as inactive if releases tool not present (#9001) test(e2e): add unarchive / unpublish tests to releases (#8979) test: adding videos to CI report artifact (#8990) fix(cli): use outpath as package name for apps (#9003) fix(core): drop explicit `withCredentials` on requests (#8996) chore: add presentation to regular workspace (#8997) fix(core): use publishedId for search intent links (#8980) chore: fix vitest snapshot client error (#8993) chore: add vitest typecheck support (#8994) fix(core): stickyParams for `__unsafe_disableScopedSearchParams` (#8987) fix: no releases screen shows the create release dialog (#8988) fix(presentation): previewUrl is required (#8995) fix(deps): update dependency @portabletext/editor to ^1.40.3 (#8992) fix(deps): update dependency @portabletext/block-tools to ^1.1.14 (#8991) feat(core): add version to documents when creating with a release pinned (#8974) fix(test): update flaky navbar test (#8984) chore: add simple e2e presentation test (#8982) chore(deps): update dev-non-major (#8983) ...
Description
What to review
Testing
Scroll down and see the comment, or click here.
Open up the report, or try this one generated already, and navigate to one of the flakey tests to see that a video recording is available
Notes for release
N/A - relates only to DX on Studio