fix(sanity): treat releases as inactive if releases tool not present #9001
+43
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
No changes to documentation |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
⚡️ Editor Performance ReportUpdated Thu, 20 Mar 2025 12:49:43 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
pedrobonamin
approved these changes
Mar 21, 2025
bjoerge
added a commit
that referenced
this pull request
Mar 21, 2025
* next: (81 commits) fix(presentation): use `perspectiveStack` when resolving main document (#9005) fix(core): hide discard changes action when published (#9009) fix(sanity): treat releases as inactive if releases tool not present (#9001) test(e2e): add unarchive / unpublish tests to releases (#8979) test: adding videos to CI report artifact (#8990) fix(cli): use outpath as package name for apps (#9003) fix(core): drop explicit `withCredentials` on requests (#8996) chore: add presentation to regular workspace (#8997) fix(core): use publishedId for search intent links (#8980) chore: fix vitest snapshot client error (#8993) chore: add vitest typecheck support (#8994) fix(core): stickyParams for `__unsafe_disableScopedSearchParams` (#8987) fix: no releases screen shows the create release dialog (#8988) fix(presentation): previewUrl is required (#8995) fix(deps): update dependency @portabletext/editor to ^1.40.3 (#8992) fix(deps): update dependency @portabletext/block-tools to ^1.1.14 (#8991) feat(core): add version to documents when creating with a release pinned (#8974) fix(test): update flaky navbar test (#8984) chore: add simple e2e presentation test (#8982) chore(deps): update dev-non-major (#8983) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are various parts of the codebase that rely on
releases.enabledfrom the workspace configuration to determine whether releases—and the releases tool—are available. This check fails whenreleases.enabledistrue, but the releases tool is later removed (e.g. in the workspace tool filter).In this scenario, Studio crashes because
ReleasesNavattempts to generate a link to the nonexistent releases tool.This branch fixes the problem by instead basing the availability of releases on the presence of the releases tool in the workspace.
What to review
The parts of the UI that rely on this check correctly respond to the presence of the releases tool.
Testing
Tested manually by adding the following
toolfilter todefaultWorkspacein Test Studio:Also verified this works as expected when removing the tool filter and setting
releases.enabledtofalse.Notes for release
Fixes a bug causing Studio to crash with error
Unable to find matching route for statewhen the releases tool is not present (e.g. when the workspace tools filter removes it).