Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add japgolly libraries to 2.12 build #368

Closed
SethTisue opened this issue Oct 25, 2016 · 4 comments · Fixed by #370
Closed

add japgolly libraries to 2.12 build #368

SethTisue opened this issue Oct 25, 2016 · 4 comments · Fixed by #370
Assignees
@SethTisue

Comments

@SethTisue
Copy link
Member

SethTisue commented Oct 25, 2016 •
edited
Loading

nyaya, and maybe others? this would have caught scala/scala-dev#248

prompted by https://groups.google.com/d/msg/scala-internals/LGRU1gEwRgQ/_28LI2jUBAAJ

@japgolly let's discuss
@SethTisue SethTisue self-assigned this Oct 25, 2016
@SethTisue SethTisue mentioned this issue Oct 25, 2016
Merged
@SethTisue SethTisue changed the title add japgolly/nyaya to 2.12 build add japgolly libraries to 2.12 build Oct 25, 2016
@japgolly
Copy link

Ok considering the Eligibility page, I think it'd be a good idea to add this subset of my libraries to the community build:

SethTisue added a commit to SethTisue/community-build that referenced this issue Oct 26, 2016
@SethTisue
add more japgolly libraries: test-state, univeq
04a7816 
as he suggested at scala#368
@SethTisue
Copy link
Member Author

ok, I'll pile all of that into the same PR and we'll see how much trouble we run into.

SethTisue added a commit to SethTisue/community-build that referenced this issue Oct 27, 2016
@SethTisue
add more japgolly libraries: test-state, univeq
b61b9ae 
as he suggested at scala#368
@japgolly
Copy link

Oh you're creating those PRs @SethTisue? Thanks! What do I need to do, if anything?

SethTisue added a commit to SethTisue/community-build that referenced this issue Oct 31, 2016
@SethTisue
add more japgolly libraries: test-state, univeq
dc32a47 
as he suggested at scala#368
@SethTisue
Copy link
Member Author

lets talk specifics at #370. I'll close this ticket, actually, since some form of the PR will surely be merged

SethTisue added a commit to SethTisue/community-build that referenced this issue Nov 23, 2016
@SethTisue
add more japgolly libraries: test-state, univeq
0aaa86c 
as he suggested at scala#368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SethTisue SethTisue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add nyaya et al SethTisue/community-build
2 participants
@SethTisue @japgolly