-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add nyaya et al #370
add nyaya et al #370
Conversation
the back end crash in nyaya is waiting on scala/scala#5479 to be merged |
univeq:
did you mean to depend on |
06de730
to
6039752
Compare
@japgolly can you change univeq to depend on the specific cats modules you need, rather than on all of cats? the other form is confusing to dbuild, and although we could try to straighten that out here, I think it would be easier if you just changed it at your end. |
now that scala/scala#5482 has been merged, I've rebased this PR and started a new test run: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/885/consoleFull (404 til Jenkins rises) |
nyaya failed with:
I believe this means you will need to upgrade nyaya to a newer version of Monocle |
@SethTisue No worries. I updated UnivEq and Nyaya, and TestState and ScalaCSS too. Could you please try again? |
trying again with 13bf6c1: |
this might go away if we built from a newer 2.12.x nightly, but we don't currently have one to use, because of scala/scala-dev#255 . so let's wait for a fix there |
there is a 2.12.1 nightly now, but now this is blocked by scalamacros/paradise#88 |
@SethTisue I've just put a 2.12.0 workaround in Nyaya master (japgolly/nyaya@e7b8418). To test the old behaviour we'd want to use revision 6dd0386b372aabe1824506261de6fccd281957f4 instead of master. |
@japgolly the paradise thing is fixed now, so we can try again. can you rebase this on top of current 2.12.x? |
Hey @SethTisue , I created a new branch with the 2.12.0 workaround reverted. Could you please use the |
sure. oh, and I'll do the rebasing, I forgot this was my PR and not yours :-) |
5bfde21
to
47c2ee6
Compare
play2-core failure is unrelated. merging! thx @japgolly |
No worries and thanks for the help. Let me know if there's anything else I can help with. |
as expected, a test run (https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/854/consoleFull) fails with:
as reported by @japgolly and under discussion at scala/scala-dev#248. so this PR shouldn't be merged until some workaround is in place
fixes #368