Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nyaya et al #370

Merged
merged 1 commit into from
Nov 29, 2016
Merged

add nyaya et al #370

merged 1 commit into from
Nov 29, 2016

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Oct 25, 2016

as expected, a test run (https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/854/consoleFull) fails with:

[nyaya:error] java.lang.AssertionError: assertion failed: 
[nyaya:error]   Cannot create ClassBType from non-class symbol type Prop
[nyaya:error]      while compiling: /home/jenkins/workspace/scala-2.12.x-integrate-community-build/target-0.9.5/project-builds/nyaya-28cbf0b1588b601b774ac136cdfe74196f25f395/nyaya-prop/src/test/scala/nyaya/prop/PropTest.scala
[nyaya:error]         during phase: jvm

as reported by @japgolly and under discussion at scala/scala-dev#248. so this PR shouldn't be merged until some workaround is in place

fixes #368

@SethTisue SethTisue changed the title add nyaya add nyaya et al Oct 26, 2016
@SethTisue
Copy link
Member Author

SethTisue commented Oct 26, 2016

the back end crash in nyaya is waiting on scala/scala#5479 to be merged

@SethTisue SethTisue self-assigned this Oct 26, 2016
@SethTisue
Copy link
Member Author

univeq:

[univeq] Processing subproject: catsJVM
[univeq] [error] **** Missing dependency: the library org.typelevel#cats is not provided (in space "default") by any project in this configuration file.
[univeq] [error] In order to control which version is used, please add the corresponding project to the build file
[univeq] [error] (or use "check-missing:false" to ignore (not recommended)).
[univeq] java.lang.RuntimeException: Required dependency not found
[univeq]    at scala.sys.package$.error(package.scala:27)
[univeq]    at com.typesafe.dbuild.plugin.DBuildRunner$$anonfun$fixModule$2.apply(DBuildRunner.scala:167)
[univeq]    at com.typesafe.dbuild.plugin.DBuildRunner$$anonfun$fixModule$2.apply(DBuildRunner.scala:142)

did you mean to depend on cats-core? I don't think just depending on cats is recommended

@SethTisue SethTisue removed their assignment Oct 26, 2016
@SethTisue SethTisue force-pushed the add-nyaya branch 2 times, most recently from 06de730 to 6039752 Compare October 31, 2016 22:16
@SethTisue
Copy link
Member Author

SethTisue commented Oct 31, 2016

@japgolly can you change univeq to depend on the specific cats modules you need, rather than on all of cats? the other form is confusing to dbuild, and although we could try to straighten that out here, I think it would be easier if you just changed it at your end.

@SethTisue
Copy link
Member Author

now that scala/scala#5482 has been merged, I've rebased this PR and started a new test run: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/885/consoleFull (404 til Jenkins rises)

@SethTisue
Copy link
Member Author

nyaya failed with:

[nyaya] [error] /home/jenkins/workspace/scala-2.12.x-integrate-community-build/target-0.9.5/project-builds/nyaya-586540391c0846a15ef3a228ca86f70765424441/nyaya-gen/src/test/scala/nyaya/gen/DistinctTest.scala:3: object Lenser is not a member of package monocle.macros
[nyaya] [error] import monocle.macros.Lenser
[nyaya] [error]        ^
[nyaya] [error] /home/jenkins/workspace/scala-2.12.x-integrate-community-build/target-0.9.5/project-builds/nyaya-586540391c0846a15ef3a228ca86f70765424441/nyaya-gen/src/test/scala/nyaya/gen/DistinctTest.scala:14: not found: type Lenser
[nyaya] [error]   val pl = new Lenser[Person]
[nyaya] [error]                ^
[nyaya] [error] /home/jenkins/workspace/scala-2.12.x-integrate-community-build/target-0.9.5/project-builds/nyaya-586540391c0846a15ef3a228ca86f70765424441/nyaya-gen/src/test/scala/nyaya/gen/DistinctTest.scala:18: not found: type Lenser
[nyaya] [error]   val sl = new Lenser[Stuff]
[nyaya] [error]                ^
[nyaya] [error] three errors found
[nyaya] [error] (nyaya-gen-jvm/test:compileIncremental) Compilation failed

I believe this means you will need to upgrade nyaya to a newer version of Monocle

@japgolly
Copy link

japgolly commented Nov 1, 2016

@SethTisue No worries. I updated UnivEq and Nyaya, and TestState and ScalaCSS too. Could you please try again?

@SethTisue
Copy link
Member Author

@SethTisue
Copy link
Member Author

SethTisue commented Nov 1, 2016

[nyaya:error] java.lang.RuntimeException: These subprojects were not found: "nyaya-test-jvm". Found: "root", "testsJS", "utilJS", "utilJVM", "propJS", "testsJVM", "propJVM", "genJS", "genJVM", "benchmark".

trying again with 13bf6c1: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/889/consoleFull https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/890/consoleFull

@SethTisue SethTisue self-assigned this Nov 1, 2016
@SethTisue
Copy link
Member Author

[nyaya:error] java.lang.AssertionError: assertion failed: 
[nyaya:error]   Cannot create ClassBType from non-class symbol type Prop
[nyaya:error]      while compiling: /home/jenkins/workspace/scala-2.12.x-integrate-community-build/target-0.9.5/project-builds/nyaya-0d957fa5e9982043133d7bb5fd18e6bf2a021922/prop/shared/src/test/scala/nyaya/prop/PropTest.scala
[nyaya:error]         during phase: jvm
[nyaya:error]      library version: version 2.12.0-4a487ca-nightly
[nyaya:error]     compiler version: version 2.12.0-4a487ca-nightly

this might go away if we built from a newer 2.12.x nightly, but we don't currently have one to use, because of scala/scala-dev#255 . so let's wait for a fix there

@SethTisue
Copy link
Member Author

SethTisue commented Nov 2, 2016

there is a 2.12.1 nightly now, but now this is blocked by scalamacros/paradise#88

@japgolly
Copy link

japgolly commented Nov 4, 2016

@SethTisue I've just put a 2.12.0 workaround in Nyaya master (japgolly/nyaya@e7b8418). To test the old behaviour we'd want to use revision 6dd0386b372aabe1824506261de6fccd281957f4 instead of master.

@SethTisue SethTisue removed their assignment Nov 9, 2016
@SethTisue
Copy link
Member Author

@japgolly the paradise thing is fixed now, so we can try again. can you rebase this on top of current 2.12.x?

@japgolly
Copy link

Hey @SethTisue , I created a new branch with the 2.12.0 workaround reverted. Could you please use the 2.12.x branch for now

@SethTisue
Copy link
Member Author

sure. oh, and I'll do the rebasing, I forgot this was my PR and not yours :-)

@SethTisue SethTisue force-pushed the add-nyaya branch 2 times, most recently from 5bfde21 to 47c2ee6 Compare November 29, 2016 22:34
@SethTisue SethTisue self-assigned this Nov 29, 2016
@SethTisue
Copy link
Member Author

@SethTisue
Copy link
Member Author

play2-core failure is unrelated. merging! thx @japgolly

@SethTisue SethTisue merged commit 7c0c3b2 into scala:2.12.x Nov 29, 2016
@SethTisue SethTisue deleted the add-nyaya branch November 29, 2016 23:44
@japgolly
Copy link

No worries and thanks for the help. Let me know if there's anything else I can help with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add japgolly libraries to 2.12 build
2 participants