Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DCRBaselineProtection Metric #728

Merged

Conversation

lajohn4747
Copy link
Contributor

@lajohn4747 lajohn4747 commented Feb 19, 2025

resolves #720
CU-86b3w869f

Average of 84 secs to run a synthetic sample of size 1000 to run against the demo dataset fake_hotels_guest (400 rows used for training and 100 rows used for validation) without subsampling.

@sdv-team
Copy link
Contributor

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.47%. Comparing base (b1d3612) to head (9ce76f0).
Report is 1 commits behind head on dcr_feature_branch.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           dcr_feature_branch     #728      +/-   ##
======================================================
+ Coverage               95.39%   95.47%   +0.07%     
======================================================
  Files                     114      115       +1     
  Lines                    4491     4570      +79     
======================================================
+ Hits                     4284     4363      +79     
  Misses                    207      207              
Flag Coverage Δ
integration 80.30% <100.00%> (+0.34%) ⬆️
unit 83.69% <100.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lajohn4747 lajohn4747 self-assigned this Feb 19, 2025
@lajohn4747 lajohn4747 marked this pull request as ready for review February 19, 2025 23:07
@lajohn4747 lajohn4747 requested a review from a team as a code owner February 19, 2025 23:07
@@ -148,3 +148,16 @@ def allow_nan_array(attributes):
ret.append(entry)

return ret


def validate_num_samples_num_iteration(num_rows_subsample, num_iterations):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting this in a separate function as we reuse this for DCROverfittingProtection.

@lajohn4747 lajohn4747 marked this pull request as ready for review February 26, 2025 05:28
Copy link
Contributor

@R-Palazzo R-Palazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

I just let 1 or 2 suggestions

Base automatically changed from issue_720_dcr_baseline_protection to dcr_feature_branch February 26, 2025 15:12
@lajohn4747 lajohn4747 merged commit b53dd20 into dcr_feature_branch Feb 27, 2025
55 checks passed
@lajohn4747 lajohn4747 deleted the issue_720_complete_dcr_baseline_protection branch February 27, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants