Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DCRBaselineProtection and DCROverfittingProtection metrics #735

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lajohn4747
Copy link
Contributor

This is the feature branch for #719 and #720.

resolves #719
resolves #720
CU-86b3w869f
CU-86b3w7pbq

This branch consists of only approved PRs:
#726
#728
#733

@sdv-team
Copy link
Contributor

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.47%. Comparing base (7f08c1e) to head (5981756).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #735      +/-   ##
==========================================
+ Coverage   95.29%   95.47%   +0.17%     
==========================================
  Files         112      115       +3     
  Lines        4378     4570     +192     
==========================================
+ Hits         4172     4363     +191     
- Misses        206      207       +1     
Flag Coverage Δ
integration 80.30% <97.39%> (+0.72%) ⬆️
unit 83.69% <100.00%> (+0.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lajohn4747
Copy link
Contributor Author

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.69%. Comparing base (7f08c1e) to head (5981756).

❗ There is a different number of reports uploaded between BASE (7f08c1e) and HEAD (5981756). Click for more details.
HEAD has 1 upload less than BASE

Flag
BASE (7f08c1e)
HEAD (5981756)

integration
1
0

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #735       +/-   ##
===========================================
- Coverage   95.29%   83.69%   -11.60%     
===========================================
  Files         112      115        +3     
  Lines        4378     4570      +192     
===========================================
- Hits         4172     3825      -347     
- Misses        206      745      +539     

Flag Coverage Δ
integration ?
unit 83.69% <100.00%> (+0.71%) ⬆️
Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

Strange as each of these PRs, code coverage was improved as it tested everything but the combination seems to throw it off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DCRBaselineProtection metric Add DCROverfittingProtection metric
2 participants