molecule converge -> test #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance
approved these changes
Mar 21, 2025
bkabrda
reviewed
Mar 24, 2025
| @@ -169,6 +169,7 @@ | |||
| old_root_content != tas_single_node_fulcio.root_ca | |||
| and (tas_single_node_fulcio.private_key != "" | |||
| or (certs_dir_files.files | selectattr('path', 'equalto', tas_single_node_remote_fulcio_auto_generated_private_key) | list | length) == 0) | |||
| changed_when: false | |||
There was a problem hiding this comment.
This changed_when shouldn't really be necessary IMO. Assuming the when logic works fine, this task will only trigger if a certain config change happened, but rerunning again after that shouldn't trigger it again, should it?
There was a problem hiding this comment.
Correct - I checked again after this comment and realized the slurped content was not being decoded hence it being wrong on every single run. Fulcio should now be all fixed (I pray)
fghanmi
reviewed
Mar 24, 2025
| @@ -166,10 +166,9 @@ | |||
| remote_src: true | |||
| mode: '0600' | |||
| when: > | |||
| old_root_content != tas_single_node_fulcio.root_ca | |||
| old_root_content.content | b64decode != tas_single_node_fulcio.root_ca | |||
There was a problem hiding this comment.
@SequeI
could you please do the same for
(better to have this change in the same PR)
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed converge -> test
Fixed one task to pass idempotence checks
Should be all good now, esp for finding more issues and bugs