Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

molecule converge -> test #195

Merged
merged 4 commits into from
Mar 24, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/molecule-converge/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,4 @@ runs:
run: |
source venv/bin/activate
molecule reset
molecule -v converge --scenario-name ${{ inputs.scenario }}
molecule -v test --scenario-name ${{ inputs.scenario }} --destroy=never
4 changes: 2 additions & 2 deletions roles/tas_single_node/tasks/certificates.yml
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@
(certs_dir_files.files | selectattr('path', 'equalto', tas_single_node_remote_fulcio_private_key) | list | length) != 0
and
(old_key_content.content | b64decode != tas_single_node_fulcio.private_key
or old_root_content != tas_single_node_fulcio.root_ca)
or old_root_content.content | b64decode != tas_single_node_fulcio.root_ca)
block:
- name: Back-up old provided private key
ansible.builtin.copy:
Expand All @@ -166,7 +166,7 @@
remote_src: true
mode: '0600'
when: >
old_root_content != tas_single_node_fulcio.root_ca
old_root_content.content | b64decode != tas_single_node_fulcio.root_ca
Copy link
Collaborator

@fghanmi fghanmi Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SequeI
could you please do the same for

or old_root_content != tas_single_node_fulcio.root_ca)
?

(better to have this change in the same PR)
Thanks!

and (tas_single_node_fulcio.private_key != ""
or (certs_dir_files.files | selectattr('path', 'equalto', tas_single_node_remote_fulcio_auto_generated_private_key) | list | length) == 0)

Expand Down
Loading