Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't package big-data-url.css and color3_hsl.json #169

Closed
jdm opened this issue Jul 5, 2017 · 2 comments
Closed

Don't package big-data-url.css and color3_hsl.json #169

jdm opened this issue Jul 5, 2017 · 2 comments

Comments

@jdm
Copy link
Member

jdm commented Jul 5, 2017

They are files that are >100k and trigger the large file error when vendoring in mozilla-central. If we could avoid packaging them, that would be nice.
@SimonSapin
Copy link
Member

http://doc.crates.io/manifest.html#the-exclude-and-include-fields-optional

@SimonSapin
Copy link
Member

If we’re removing test files all of src/css-parsing-tests should also be removed, even files under 100k.

froydnj added a commit to froydnj/rust-cssparser that referenced this issue Jul 6, 2017
@froydnj
actually exclude test files from packaging
1509db2 
package.exclude takes glob syntax for determining what files to exclude
when excluding directories.

Fixes servo#169.
This was referenced Jul 6, 2017
Merged
Closed
froydnj added a commit to froydnj/rust-cssparser that referenced this issue Jul 6, 2017
@froydnj
actually exclude test files from packaging
2129da6 
package.exclude takes glob syntax for determining what files to exclude
when excluding directories.  big-data-url.css is also quite large and
should be excluded from packaging as well.

Fixes servo#169.
bors-servo pushed a commit that referenced this issue Jul 6, 2017
Auto merge of #170 - froydnj:test-file-packaging, r=SimonSapin
e009794 
actually exclude test files from packaging

package.exclude takes glob syntax for determining what files to exclude
when excluding directories.

Fixes #169.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/170)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdm @SimonSapin