Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actually exclude test files from packaging #170

Merged
merged 1 commit into from
Jul 6, 2017
Merged

actually exclude test files from packaging #170

merged 1 commit into from
Jul 6, 2017

Conversation

froydnj
Copy link
Contributor

@froydnj froydnj commented Jul 6, 2017 •
edited by larsbergstrom
Loading

package.exclude takes glob syntax for determining what files to exclude
when excluding directories.

Fixes #169.

This change is Reviewable

@froydnj
Copy link
Contributor Author

froydnj commented Jul 6, 2017

This is untested, but I can see the test files vendored in Firefox's repo with the present setup, so the present setup is obviously doing the wrong thing.

@froydnj
Copy link
Contributor Author

froydnj commented Jul 6, 2017

Hm, actually I'm not sure if it should be src/css-parsing-tests/**, src/css-parsing-tests/*, or src/css-parsing-tests/**/*...

@SimonSapin
Copy link
Member

You can test by running cargo package and examining the tarball created somewhere under target/.

@froydnj
Copy link
Contributor Author

froydnj commented Jul 6, 2017

You can test by running cargo package and examining the tarball created somewhere under target/.

Aha, thanks! Running cargo package indicates that 1509db2 does indeed prevent the tests from being packaged, so I think this PR is good to go!

@SimonSapin
Copy link
Member

Could you also add big-data-url.css to the list? r=me with that. Thanks!

@froydnj
actually exclude test files from packaging
2129da6 
package.exclude takes glob syntax for determining what files to exclude
when excluding directories.  big-data-url.css is also quite large and
should be excluded from packaging as well.

Fixes servo#169.
@froydnj froydnj force-pushed the test-file-packaging branch from 1509db2 to 2129da6 Compare July 6, 2017 20:56
@froydnj
Copy link
Contributor Author

froydnj commented Jul 6, 2017

Done, thanks!

@SimonSapin
Copy link
Member

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 2129da6 has been approved by SimonSapin

@bors-servo
Copy link
Contributor

⌛ Testing commit 2129da6 with merge e009794...

bors-servo pushed a commit that referenced this pull request Jul 6, 2017
Auto merge of #170 - froydnj:test-file-packaging, r=SimonSapin
e009794 
actually exclude test files from packaging

package.exclude takes glob syntax for determining what files to exclude
when excluding directories.

Fixes #169.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/170)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: SimonSapin
Pushing e009794 to master...

@bors-servo bors-servo merged commit 2129da6 into servo:master Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@froydnj @SimonSapin @bors-servo