Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle different certificate fields correctly #176

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

woodruffw
Copy link
Member

@woodruffw woodruffw commented Jan 9, 2025

WIP; still root causing the failure that surfaced this.

This checks both x509_certificate_chain and certificate in the test_sign_does_not_produce_root test, since clients can place bundled certificates in either (and as of v3 bundles, are required to use the latter instead of the former).

xref https://github.com/sigstore/sigstore-go/actions/runs/12697653217

CC @haydentherapper

Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw
Copy link
Member Author

Current hypothesis: other clients that were running this test were generating v2 and older bundles, which generally use x509_certificate_chain.

@haydentherapper
Copy link
Collaborator

haydentherapper commented Jan 9, 2025

I believe this is related to bumping betterproto, sigstore/protobuf-specs#404. As noted in https://github.com/danielgtaylor/python-betterproto/releases/tag/v.2.0.0b7, accessing an unset field not throws an error.

@woodruffw
Copy link
Member Author

Nice catch! Okay, this makes sense to me then!

@woodruffw woodruffw self-assigned this Jan 9, 2025
@woodruffw woodruffw merged commit 3a18960 into main Jan 9, 2025
7 checks passed
@woodruffw woodruffw deleted the ww/check-certificate-too branch January 9, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants