Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle different certificate fields correctly #176

Merged
merged 1 commit into from
Jan 9, 2025
Merged

handle different certificate fields correctly #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions test/test_bundle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,14 @@ def test_sign_does_not_produce_root(
bundle = Bundle().from_json(bundle_contents)

# Iterate over our cert chain and check for roots.
certs = bundle.verification_material.x509_certificate_chain
for x509cert in certs.certificates:
if bundle.verification_material.is_set("x509_certificate_chain"):
certs = bundle.verification_material.x509_certificate_chain.certificates
elif bundle.verification_material.is_set("certificate"):
certs = [bundle.verification_material.certificate]
else:
assert False, "expected certs in either `x509_certificate_chain` or `certificate`"

for x509cert in certs:
cert = x509.load_der_x509_certificate(x509cert.raw_bytes)

try:
Expand Down
Loading