This repository was archived by the owner on Jan 22, 2025. It is now read-only.
refactor(experimental): a function to convert a public key into a base 58 encoded address #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 13, 2023
steveluscher
force-pushed
the
pr1394
branch
2 times, most recently
from
9134ea7 to
9efb275
Compare
mcintyre94
approved these changes
Jul 14, 2023
steveluscher
force-pushed
the
pr1394
branch
2 times, most recently
from
921fbe0 to
0239646
Compare
…e 58 encoded address ## Summary This is useful in cases where you, yourself, generated a keypair, and now you need to display the public key in your UI. Otherwise, you will typically already have the `Base58EncodedAddress` object. ## Test Plan ``` cd packages/keys/ pnpm test:unit:browser pnpm test:unit:node ```
|
🎉 This PR is included in version 1.78.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(experimental): a function to convert a public key into a base 58 encoded address
Summary
This is useful in cases where you, yourself, generated a keypair, and now you need to display the public key in your UI. Otherwise, you will typically already have the
Base58EncodedAddressobject.Test Plan
Stack created with Sapling. Best reviewed with ReviewStack.
SubtleCrypto#verify#1400SubtleCrypto#sign#1399SubtleCrypto#exportKey#1397CryptoKeybelongs to the polyfill or not #1396generateKey()that implements Ed25519 key generation in userspace #1395