This repository was archived by the owner on Jan 22, 2025. It is now read-only.
refactor(experimental): a function that tells you whether a CryptoKey belongs to the polyfill or not
#1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 13, 2023
steveluscher
force-pushed
the
pr1396
branch
8 times, most recently
from
0b6a4d3 to
b535354
Compare
steveluscher
requested review from
joncinque,
jordaaash,
mcintyre94 and
buffalojoec
…y` belongs to the polyfill or not ## Summary Only keys produced with the polyfill's `generateKey` method are usable with its other methods. Having been produced with the polyfill keygen is the same as ‘being present in the key store,’ hence this simple test. ## Test Plan ``` cd packages/webcrypto-ed25519-polyfill pnpm test:unit:browser pnpm test:unit:node ```
buffalojoec
reviewed
Jul 18, 2023
We're using Semantic Release, it has opinions about how commit messages should be written, I hate it, and we'll probably replace it with Changesets by Breakpoint. |
|
In this case it's probably complaining that my commit message is too long, to which I say
|
buffalojoec
approved these changes
Jul 18, 2023
This was referenced Jul 19, 2023
This was referenced Jul 21, 2023
|
🎉 This PR is included in version 1.78.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(experimental): a function that tells you whether a
CryptoKeybelongs to the polyfill or notSummary
Only keys produced with the polyfill's
generateKeymethod are usable with its other methods. Having been produced with the polyfill keygen is the same as ‘being present in the key store,’ hence this simple test.Test Plan
Stack created with Sapling. Best reviewed with ReviewStack.
truethe default forisSecureContextin tests #1412SubtleCrypto#verify#1400SubtleCrypto#sign#1399SubtleCrypto#exportKey#1397CryptoKeybelongs to the polyfill or not #1396