Drop FOSUserBundle with minimum functionality #1256

wbloszyk · 2020-10-15T17:11:21Z

Subject

This PR move minimul functionality from FOSUserBundle which will be allow using SonataUserBundle without FOSUserBundle dependencies/inheritance.

I am targeting this branch, because this change are BC-BREAK.

Closes #1255

Changelog

### Added
- Added some `Class::newMethod()` to do great stuff.

### Changed

### Deprecated

### Removed

### Fixed

### Security

To do

Update the tests;
Update the documentation;
Add an upgrade note.

SonataCI · 2020-11-13T06:35:07Z

Could you please rebase your PR and fix merge conflicts?

eerison · 2020-11-17T08:58:09Z

composer.json

@@ -23,7 +23,6 @@
    "require": {
        "php": "^7.2",
        "doctrine/common": "^2.0",
-        "friendsofsymfony/user-bundle": "^2.0",


@wbloszyk I removed FosUserBundle from other project and I needed to add

symfony/security-bundle ("maybe" you don't need this because we are adding symfony/security-core)

doctrine/annotations

symfony/validator

wbloszyk · 2021-02-08T14:43:51Z

@sonata-project/contributors Can you check it? IMO it is good star point to work on SonataUserBundle v4.

VincentLanglet · 2021-02-08T14:52:02Z

docs/reference/advanced_configuration.rst

-        class:                  # Entity Classes
-            user:               Application\Sonata\UserBundle\Entity\User
-            group:              Application\Sonata\UserBundle\Entity\Group
+        class: # Entity Classes
+            user: 'App\Entity\SonataUserUser'
+            group: 'App\Entity\SonataUserGroup'


Previously the entity was in the UserBundle, now it have to be created by the user ?
Cant/Shouldnt we provide a User class ?

Previus we are using EasyExtendsBundle to do it in Application\Sonata\UserBundle\Entity\User.
IMO in UserBundle v4 we should provide recipies with default entities. Using Sonata\UserBundle\Entity\BaseUser will be also allowed.

So we shouldn't use 'App\Entity\SonataUserUser' in the config
But 'Sonata\UserBundle\Entity\User'

I recheck it. It is not possible to use Sonata\UserBundle\Entity\BaseUser. I think it is not possible to provide User class in easy way. We should not provide User identifier by own and can not use two User classes for one entity. So we must keep App\Entity\SonataUserUser

Why ?

You still provide the classes BaseUser and a BaseGroup. What's wrong with them.

But these classes must be override to configure identifier for them. Also in other bundles we are using App\Entity\Sonata*

https://github.com/sonata-project/SonataPageBundle/blob/3.x/docs/reference/advanced_configuration.rst
https://github.com/sonata-project/SonataArticleBundle/blob/1.x/docs/reference/configuration.rst
https://github.com/sonata-project/SonataMediaBundle/blob/3.x/docs/reference/advanced_configuration.rst
https://github.com/sonata-project/SonataNewsBundle/blob/3.x/docs/reference/advanced_configuration.rst

Ok, so we should add a note about the interface that the customUser/Group need to implements and be sure it's clear we provide a Base class to help developers.

I did not work on upgrade note jet. I waiting for appove current change. Then I will update note based on approved changes.

docs/reference/installation.rst

docs/reference/two_step_validation.rst

VincentLanglet · 2021-02-08T14:55:30Z

src/DependencyInjection/SonataUserExtension.php

+        $container->setAlias('sonata.user.util.email_canonicalizer', $config['service']['email_canonicalizer']);
+        $container->setAlias('sonata.user.util.username_canonicalizer', $config['service']['username_canonicalizer']);
+        $container->setAlias('sonata.user.util.token_generator', $config['service']['token_generator']);
+        //$container->setAlias('sonata.user.user_manager', new Alias($config['service']['user_manager'], true));


This utils was moved from FOSUserBundle (to keep the same functionality like with FOSUSer). In next PRs we can remove it.

I mean, why is there a line commented ?

Becouse it this alias is create in line 305. For now I do not know what to do with it.

SonataCI · 2021-02-10T02:15:05Z

Could you please rebase your PR and fix merge conflicts?

Webonaute · 2021-05-17T15:59:00Z

any advancement on this?

VincentLanglet · 2021-05-17T16:49:51Z

any advancement on this?

Feel free to overtake the pr

SonataCI · 2021-05-21T14:12:02Z

Could you please rebase your PR and fix merge conflicts?

FlintCIBot · 2021-05-21T14:22:07Z

src/Resources/translations/SonataUserBundle.ja.yaml

+
+            パスワードをリセットするには、次のリセット URL へアクセスしてください %confirmationUrl%
+
+


yamllint: too many blank lines (2 > 1) (empty-lines)

SonataCI · 2021-08-11T17:20:48Z

Could you please rebase your PR and fix merge conflicts?

VincentLanglet · 2021-12-13T18:37:56Z

Closed in favor of #1449

wbloszyk requested a review from a team October 15, 2020 17:11

wbloszyk changed the title ~~Minimum drop fos user~~ Drop FOSUserBundle with minimum functionality Oct 15, 2020

wbloszyk added major hacktoberfest labels Oct 15, 2020

wbloszyk requested review from jordisala1991 and phansys October 17, 2020 09:22

SonataCI added the pending author label Nov 13, 2020

eerison reviewed Nov 17, 2020

View reviewed changes

wbloszyk force-pushed the minimum_drop_fos_user branch from 11aee55 to 90076b5 Compare February 8, 2021 14:30

SonataCI removed the pending author label Feb 8, 2021

wbloszyk force-pushed the minimum_drop_fos_user branch from d95e577 to 8e996a5 Compare February 8, 2021 14:38

VincentLanglet reviewed Feb 8, 2021

View reviewed changes

wbloszyk requested review from VincentLanglet and a team February 8, 2021 15:33

SonataCI added pending author and removed pending author labels Feb 10, 2021

wbloszyk added 9 commits May 21, 2021 16:03

Add security

c84d6ad

Add utils

940707e

Add translations

9f6ddfb

Replace FOS\User to Sonata\User usage

168f9cc

Remove FOSUser

ba50fcf

Update doc

bc95ff8

Fix resetting process

e694d44

Fix cs

88b6cf9

Pedantic

351a5c0

wbloszyk force-pushed the minimum_drop_fos_user branch from 7fa7c50 to 351a5c0 Compare May 21, 2021 14:06

SonataCI added the pending author label May 21, 2021

Merge branch 'master' into minimum_drop_fos_user

3e738ab

SonataCI removed the pending author label May 21, 2021

FlintCIBot reviewed May 21, 2021

View reviewed changes

VincentLanglet marked this pull request as draft June 13, 2021 16:07

SonataCI added the pending author label Aug 11, 2021

jordisala1991 mentioned this pull request Dec 9, 2021

Remove FOSUserBundle #1449

Merged

VincentLanglet closed this Dec 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop FOSUserBundle with minimum functionality #1256

Drop FOSUserBundle with minimum functionality #1256

wbloszyk commented Oct 15, 2020 •

edited

Loading

SonataCI commented Nov 13, 2020

eerison Nov 17, 2020

wbloszyk commented Feb 8, 2021

VincentLanglet Feb 8, 2021

wbloszyk Feb 8, 2021

VincentLanglet Feb 8, 2021

wbloszyk Feb 13, 2021

VincentLanglet Feb 13, 2021

wbloszyk Feb 13, 2021

VincentLanglet Feb 13, 2021

wbloszyk Feb 13, 2021

VincentLanglet Feb 8, 2021

wbloszyk Feb 8, 2021

VincentLanglet Feb 8, 2021

wbloszyk Feb 8, 2021

SonataCI commented Feb 10, 2021

Webonaute commented May 17, 2021

VincentLanglet commented May 17, 2021

SonataCI commented May 21, 2021

FlintCIBot May 21, 2021

SonataCI commented Aug 11, 2021

VincentLanglet commented Dec 13, 2021


		パスワードをリセットするには、次のリセット URL へアクセスしてください %confirmationUrl%

Drop FOSUserBundle with minimum functionality #1256

Drop FOSUserBundle with minimum functionality #1256

Conversation

wbloszyk commented Oct 15, 2020 • edited Loading

Subject

Changelog

To do

SonataCI commented Nov 13, 2020

Choose a reason for hiding this comment

wbloszyk commented Feb 8, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SonataCI commented Feb 10, 2021

Webonaute commented May 17, 2021

VincentLanglet commented May 17, 2021

SonataCI commented May 21, 2021

Choose a reason for hiding this comment

SonataCI commented Aug 11, 2021

VincentLanglet commented Dec 13, 2021

wbloszyk commented Oct 15, 2020 •

edited

Loading