Remove FOSUserBundle

[jordisala1991]

Subject

I am targeting this branch, because this will break bc.

Closes #1256 #1112

This PR tries to remove FOSUserBundle with the minimal code needed:

• Remove FOSUserBundle from dependencies
• Add missing files from FOSUser that are needed to make test green
• Add missing translations here
• Pass all the Github Actions defined

This PR will not (Those will go in separate PRs once this one is accepted, and only if really needed):

• Add support for more Symfony versions
• Reduce the UserInterface
• Remove / Deprecate the groups feature
• Add commands or another features from FOSUserBundle that are not mandatory to pass tests
• Use symfonycasts/reset-password-bundle to reset password

This PR needs: #1444

I tried to be consistent with what is done on other bundles with the managers and entities and models. (I also discovered some things that can be improved on media-bundle and probably on classification-bundle).

Keep in mind that this code can change in nexts PRs when we need to add more things like commands or other things. This is just a first version to be able to remove FOSUserBundle and enable next Symfony versions. It also does not make sense to port this to stable branch, because it will be a huge effort for not that much benefit.

Changelog

### Removed
- Removed FOSUserBundle dependency.

[jordisala1991]

Things missing:

• Canonicalization of fields
• Make sure nothing of FOS is left
• Check if LoginManager is really needed, only used on ResetAction
• Add LastLogin listener
• Check validation
• Add Remember me compiler pass (if LoginManager is needed)
• Check Symfony requirements
• Add missing configuration options present in FOSUser (need to remove the hardcoded values)
• Check if some unit test can be copied from FOSUser
• Move english translations

[jordisala1991]

I would like to get some reviews, @sonata-project/contributors . The PR is mostly done, the code should be okay. (Remember that we are not trying to have one PR that lets this bundle perfect, but we are only trying to remove FOSUser)

I copied the needed translations only for english to validate we are not missing any.

@Hanmac or @eerison , or really any other user of this bundle: If you can try this PR in your projects it will be helpful too (Note that even if we removed FOSUser, this bundle is still not compatible with SF 6, it will be on a future PR to not grow this one bigger and bigger)

[wbloszyk]

@sonata-project/contributors
WDYT about reduce UserBundle only to integrate User with Admin bundle?
IMO we should not provide a fully user management but only expands Symfony user (or Sonata User) by Groups.

[jordisala1991]

@sonata-project/contributors
WDYT about reduce UserBundle only to integrate User with Admin bundle?
IMO we should not provide a fully user management but only expands Symfony user (or Sonata User) by Groups.

I am not sure to follow you on what needs to be changed then. IMHO I have reduced to only a minimal integration with User and Admin.

And please, keep in mind this Pr is big enough and it is not intended to hold all the code changes needed to release a new version. Check my next PR to see how easy it is to add sf 5 and 6 once this one is merged: #1454

[wbloszyk]

@sonata-project/contributors
WDYT about reduce UserBundle only to integrate User with Admin bundle?
IMO we should not provide a fully user management but only expands Symfony user (or Sonata User) by Groups.

I am not sure to follow you on what needs to be changed then. IMHO I have reduced to only a minimal integration with User and Admin.

And please, keep in mind this Pr is big enough and it is not intended to hold all the code changes needed to release a new version. Check my next PR to see how easy it is to add sf 5 and 6 once this one is merged: #1454

So I start working on POC in 4.x.

[jordisala1991]

@sonata-project/contributors
WDYT about reduce UserBundle only to integrate User with Admin bundle?
IMO we should not provide a fully user management but only expands Symfony user (or Sonata User) by Groups.

I am not sure to follow you on what needs to be changed then. IMHO I have reduced to only a minimal integration with User and Admin.
And please, keep in mind this Pr is big enough and it is not intended to hold all the code changes needed to release a new version. Check my next PR to see how easy it is to add sf 5 and 6 once this one is merged: #1454

So I start working on POC in 4.x.

To me the work is already done, if you have some specific things to change, please add your comments, but do not block the PR.

[wbloszyk]

@sonata-project/contributors
WDYT about reduce UserBundle only to integrate User with Admin bundle?
IMO we should not provide a fully user management but only expands Symfony user (or Sonata User) by Groups.

I am not sure to follow you on what needs to be changed then. IMHO I have reduced to only a minimal integration with User and Admin.
And please, keep in mind this Pr is big enough and it is not intended to hold all the code changes needed to release a new version. Check my next PR to see how easy it is to add sf 5 and 6 once this one is merged: #1454

So I start working on POC in 4.x.

To me the work is already done, if you have some specific things to change, please add your comments, but do not block the PR.

@jordisala1991
Can you look at: #1455
It is only example.

[jordisala1991]

@sonata-project/contributors

WDYT about reduce UserBundle only to integrate User with Admin bundle?

IMO we should not provide a fully user management but only expands Symfony user (or Sonata User) by Groups.

I am not sure to follow you on what needs to be changed then. IMHO I have reduced to only a minimal integration with User and Admin.

And please, keep in mind this Pr is big enough and it is not intended to hold all the code changes needed to release a new version. Check my next PR to see how easy it is to add sf 5 and 6 once this one is merged: #1454

So I start working on POC in 4.x.

To me the work is already done, if you have some specific things to change, please add your comments, but do not block the PR.

@jordisala1991

Can you look at: #1455

It is only example.

I have checked it and I think it is not related to this PR. You are trying to introduce a new integration not needed to remove FOSUser. An integration that has to be well thought because of the issues I mentioned.

IMO we should:

1. Finish this PR to unlock more Pr: like sf 5 and 6 support
2. Add sf 5 and 6 support ( Pr already opened)
3. Increase phpstan, psalm
4. Increase php version
5. ...

And probably one point of that is about symfony casts reset password bundle.

I dont wanna block this PR

[VincentLanglet]

There is maybe some improvements to do @wbloszyk but I think @jordisala1991 made a really good job here to help us to move forward with this project.

After this we will be able to add Symfony 5 support and improve the code quality. And we can still add things like your POC. That's not incompatible.

[jordisala1991]

Let's have this one and improve on next PRs.