Bump PHP #1438
Closed
Bump PHP #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #1437, we may need a PR to SonataAdmin3 for the 8.1 support. |
wbloszyk
force-pushed
the
bump_php_depends
branch
from
1e0a3a3 to
2edb594
Compare
So lets remove support for 7.3 only. |
|
This require a PR on devkit (to remove ci on 7.3 and revert the fact we're requiring 8.1 for the ci) |
|
IMO it does not make a lot of sense to do it on 4.x, there is a little benefit since you won't be able to add typehints and this branch won't be able to upgrade much more (because of FOS). IMO the efforts should be on 5.x branch. I already started with it. It needs a lot of cleanup to prepare for the FOSUser removal. (I will do it but I need some time). |
|
Could you please rebase your PR and fix merge conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this change respect BC.
Changelog