Drop php 7.3 and add missing typehints #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please rebase your PR and fix merge conflicts? |
jordisala1991
force-pushed
the
improvement/drop-php-7.3
branch
from
479410a to
d4a91b7
Compare
jordisala1991
changed the title
jordisala1991
force-pushed
the
improvement/drop-php-7.3
branch
from
d4a91b7 to
6f7de68
Compare
|
Could you please rebase your PR and fix merge conflicts? |
jordisala1991
force-pushed
the
improvement/drop-php-7.3
branch
from
6f7de68 to
009a2fb
Compare
jordisala1991
force-pushed
the
improvement/drop-php-7.3
branch
from
4824b9d to
4f2c810
Compare
jordisala1991
force-pushed
the
improvement/drop-php-7.3
branch
from
4f2c810 to
6ff7685
Compare
|
Dev-kit PR: sonata-project/dev-kit#1830 |
VincentLanglet
previously approved these changes
Dec 27, 2021
VincentLanglet
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this breaks BC.
Closes #1438
Changelog