Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong styles and label for steps when a PipelineRun or TaskRun is cancelled #1768

Closed
AlanGreene opened this issue Oct 15, 2020 · 4 comments
Closed
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@AlanGreene
Copy link
Member

Describe the bug

Dashboard displays cancelled steps as 'Failed'.

See the git-source init step in this example which is also using blue for the icon + status label.
image

Expected behaviour

Steps cancelled as a result of a PipelineRun / TaskRun being cancelled or timed out should be displayed as cancelled.

Steps to reproduce the bug

Environment details

  • Kubernetes Platform:
  • Kubernetes or OpenShift version:
  • Install mode (if on OpenShift):
  • Cloud-provider/provisioner:
  • Versions:
    • Tekton Dashboard:
    • Tekton Pipelines:
    • Tekton Triggers:
  • Install namespaces:
    • Tekton Dashboard: v0.10.1
    • Tekton Pipelines: v0.17.1
    • Tekton Triggers:

Additional Info

@AlanGreene AlanGreene added the kind/bug Categorizes issue or PR as related to a bug. label Oct 15, 2020
@AlanGreene AlanGreene self-assigned this Oct 15, 2020
@AlanGreene
Copy link
Member Author

AlanGreene commented Oct 15, 2020

Pipelines now updates the step status when the TaskRun is cancelled or times out. This behaviour was introduced in Pipelines v0.16.0 and results in the behaviour described above in any supported Dashboard version. PR open with a fix.

@AlanGreene
Copy link
Member Author

Fix merged and will be included in next release
/close

@tekton-robot
Copy link
Contributor

@AlanGreene: Closing this issue.

In response to this:

Fix merged and will be included in next release
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlanGreene
Copy link
Member Author

Fix is available in Dashboard v0.10.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants