Fix styles and label for cancelled steps #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/M
Pipelines now updates the status of steps for cancelled or timed out TaskRuns, see tektoncd/pipeline#3088 Update the styles and labels to display these as cancelled rather than failed (which was the fallback for unknown status/reason combos)
AlanGreene
force-pushed
the
taskruncancelled_step_style
branch
from
c9e4348 to
59856d1
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: steveodonovan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
steveodonovan
added
the
hacktoberfest-accepted
|
issue with easycla is resolved, closing the PR and reopening to re-trigger the check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
#1768
Pipelines now updates the status of steps for cancelled or timed out
TaskRuns, see tektoncd/pipeline#3088
Update the styles and labels to display these as cancelled rather
than failed (which was the fallback for unknown status/reason combos)
Before:
After:
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Includes docs (if user facing)See the contribution guide
for more details.