-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Texture Validation #116
Texture Validation #116
Conversation
3417ae9
to
cecd714
Compare
1d9db50
to
e03c11d
Compare
a3f87ec
to
473113c
Compare
bc982a8
to
482376f
Compare
e176a8c
to
b363689
Compare
482376f
to
1b497a6
Compare
584f8ce
to
f0edae5
Compare
11c982f
to
841279b
Compare
f0edae5
to
fb813d5
Compare
fb813d5
to
78c82dd
Compare
75f83ea
to
d112f0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good at the high level - @thatcosmonaut, you can squash this whenever you're ready
8fd49c9
to
233af3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic, this is a great change. Just one small typo fix needed and this can go in.
* Remove CreateTexture depth format fallback logic * Add TextureCommonHeader to vulkan/d3d11/d3d12/metal
* Remove CreateTexture depth format fallback logic * Add TextureCommonHeader to vulkan/d3d11/d3d12/metal
* Remove CreateTexture depth format fallback logic * Add TextureCommonHeader to vulkan/d3d11/d3d12/metal
* Remove CreateTexture depth format fallback logic * Add TextureCommonHeader to vulkan/d3d11/d3d12/metal
* Remove CreateTexture depth format fallback logic * Add TextureCommonHeader to vulkan/d3d11/d3d12/metal
* Remove CreateTexture depth format fallback logic * Add TextureCommonHeader to vulkan/d3d11/d3d12/metal
Setting up texture creation validation. This has the prerequisite of moving all texture metadata info to the container in a common header (#95) so I'm working on that incrementally.