Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Texture Validation #116

Merged
merged 15 commits into from
Aug 7, 2024
Merged

Texture Validation #116

merged 15 commits into from
Aug 7, 2024

Conversation

TheSpydog
Copy link
Collaborator

@TheSpydog TheSpydog commented Jul 22, 2024

Setting up texture creation validation. This has the prerequisite of moving all texture metadata info to the container in a common header (#95) so I'm working on that incrementally.

  • Move texture data to container in D3D11
  • Move texture data to container in Vulkan
  • Add the texture common header to D3D12
  • Remove depth format fallback logic from CreateTexture
    • Document the support matrix (D16 is always available, check which of D32/D24 you have before using it)
  • Add validation checks to CreateTexture
  • Add validation checks to Blit

@flibitijibibo flibitijibibo force-pushed the gpu_next branch 3 times, most recently from a3f87ec to 473113c Compare July 30, 2024 13:38
@flibitijibibo flibitijibibo force-pushed the texture_validation branch 3 times, most recently from bc982a8 to 482376f Compare August 1, 2024 01:45
@flibitijibibo flibitijibibo force-pushed the gpu_next branch 2 times, most recently from e176a8c to b363689 Compare August 1, 2024 15:01
@flibitijibibo flibitijibibo force-pushed the texture_validation branch 3 times, most recently from 584f8ce to f0edae5 Compare August 2, 2024 14:49
@flibitijibibo flibitijibibo force-pushed the gpu_next branch 3 times, most recently from 11c982f to 841279b Compare August 4, 2024 13:52
@TheSpydog TheSpydog force-pushed the texture_validation branch from fb813d5 to 78c82dd Compare August 7, 2024 14:28
@TheSpydog TheSpydog marked this pull request as ready for review August 7, 2024 18:30
@TheSpydog TheSpydog changed the title WIP: Texture Validation Texture Validation Aug 7, 2024
@TheSpydog TheSpydog requested a review from thatcosmonaut August 7, 2024 19:41
Copy link
Collaborator

@flibitijibibo flibitijibibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at the high level - @thatcosmonaut, you can squash this whenever you're ready

@TheSpydog TheSpydog force-pushed the texture_validation branch from 8fd49c9 to 233af3a Compare August 7, 2024 19:49
Copy link
Owner

@thatcosmonaut thatcosmonaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic, this is a great change. Just one small typo fix needed and this can go in.

@TheSpydog TheSpydog merged commit 112ae16 into gpu_next Aug 7, 2024
4 checks passed
@TheSpydog TheSpydog deleted the texture_validation branch August 7, 2024 22:43
flibitijibibo pushed a commit that referenced this pull request Aug 9, 2024
* Remove CreateTexture depth format fallback logic
* Add TextureCommonHeader to vulkan/d3d11/d3d12/metal
bartwe pushed a commit to bartwe/SDL-gpu-dx12 that referenced this pull request Aug 9, 2024
* Remove CreateTexture depth format fallback logic
* Add TextureCommonHeader to vulkan/d3d11/d3d12/metal
TheSpydog added a commit to bartwe/SDL-gpu-dx12 that referenced this pull request Aug 17, 2024
* Remove CreateTexture depth format fallback logic
* Add TextureCommonHeader to vulkan/d3d11/d3d12/metal
flibitijibibo pushed a commit that referenced this pull request Aug 23, 2024
* Remove CreateTexture depth format fallback logic
* Add TextureCommonHeader to vulkan/d3d11/d3d12/metal
flibitijibibo pushed a commit that referenced this pull request Aug 28, 2024
* Remove CreateTexture depth format fallback logic
* Add TextureCommonHeader to vulkan/d3d11/d3d12/metal
flibitijibibo pushed a commit that referenced this pull request Aug 28, 2024
* Remove CreateTexture depth format fallback logic
* Add TextureCommonHeader to vulkan/d3d11/d3d12/metal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants