refactor(torture): use OrdMap to track the state
#701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 17, 2025
This was referenced Jan 17, 2025
gabriele-0201
force-pushed
the
gm_torture_workload_state_back_to_ord_map
branch
from
6270d32 to
51ef2e0
Compare
gabriele-0201
force-pushed
the
gm_torture_sample_after_commit
branch
from
9adaa35 to
28037e3
Compare
gabriele-0201
force-pushed
the
gm_torture_workload_state_back_to_ord_map
branch
from
51ef2e0 to
7d8599d
Compare
This was referenced Jan 20, 2025
pepyakin
force-pushed
the
gm_torture_sample_after_commit
branch
from
28037e3 to
6fc7ac0
Compare
pepyakin
force-pushed
the
gm_torture_workload_state_back_to_ord_map
branch
from
7d8599d to
bacfdd6
Compare
pepyakin
force-pushed
the
gm_torture_sample_after_commit
branch
from
6fc7ac0 to
1763dda
Compare
pepyakin
force-pushed
the
gm_torture_workload_state_back_to_ord_map
branch
from
bacfdd6 to
2cc1b70
Compare
gabriele-0201
force-pushed
the
gm_torture_sample_after_commit
branch
from
1763dda to
a3c5384
Compare
gabriele-0201
force-pushed
the
gm_torture_workload_state_back_to_ord_map
branch
from
2cc1b70 to
3bbea42
Compare
pepyakin
force-pushed
the
gm_torture_sample_after_commit
branch
2 times, most recently
from
2b03934 to
323a7ba
Compare
pepyakin
force-pushed
the
gm_torture_workload_state_back_to_ord_map
branch
from
3bbea42 to
3eef3cc
Compare
pepyakin
reviewed
Jan 20, 2025
| if self.mentions.is_empty() || self.rng.gen_bool(self.biases.new_key) { | ||
| let mut key = [0; 32]; | ||
| let mut key = [0; 32]; | ||
| if !self.committed.state.is_empty() && self.rng.gen_bool(self.biases.delete) { |
There was a problem hiding this comment.
Why don't we want to attempt a removal on an empty state?
There was a problem hiding this comment.
To avoid deleting non-existing keys!
But now that I'm thinking about it, do we really not want to attempt to delete non-existing keys?
gabriele-0201
force-pushed
the
gm_torture_workload_state_back_to_ord_map
branch
from
3eef3cc to
544b136
Compare
This was referenced Jan 21, 2025
This was referenced Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.