chore(torture): address multiple left todos #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 23, 2025
gabriele-0201
force-pushed
the
gm_long_rollback_test
branch
from
b0fd3e2 to
e13fc49
Compare
gabriele-0201
force-pushed
the
gm_adderess_some_left_todos
branch
from
076aa0c to
2a5a9ba
Compare
gabriele-0201
force-pushed
the
gm_long_rollback_test
branch
from
e13fc49 to
b222b2c
Compare
gabriele-0201
force-pushed
the
gm_adderess_some_left_todos
branch
from
2a5a9ba to
6ac611e
Compare
gabriele-0201
force-pushed
the
gm_long_rollback_test
branch
from
b222b2c to
f810061
Compare
gabriele-0201
force-pushed
the
gm_adderess_some_left_todos
branch
from
6ac611e to
1b5865f
Compare
gabriele-0201
force-pushed
the
gm_long_rollback_test
branch
from
f810061 to
209d0cb
Compare
gabriele-0201
force-pushed
the
gm_adderess_some_left_todos
branch
2 times, most recently
from
e5bdf19 to
55aa3de
Compare
gabriele-0201
force-pushed
the
gm_long_rollback_test
branch
from
209d0cb to
d718b70
Compare
gabriele-0201
force-pushed
the
gm_adderess_some_left_todos
branch
from
55aa3de to
da7991a
Compare
pepyakin
approved these changes
Jan 28, 2025
| @@ -47,7 +47,8 @@ pub struct InitPayload { | |||
| /// Only used upon creation a new NOMT db. | |||
| pub bitbox_seed: [u8; 16], | |||
| /// Whether the agent is supposed to handle rollbacks. | |||
| pub rollback: bool, | |||
| /// If `Some`, the maximum amount of supported blocks in a single rollback is specified. | |||
There was a problem hiding this comment.
Suggested change
| /// If `Some`, the maximum amount of supported blocks in a single rollback is specified. | |
| /// If `Some`, the maximum number of supported blocks in a single rollback is specified. |
| async fn schedule_rollback(&mut self, should_crash: bool) -> anyhow::Result<()> { | ||
| let n_commits_to_rollback = self.commits_to_rollback(); | ||
| let n_commits_to_rollback = self.state.rng.gen_range(1..self.max_rollback_commits) as usize; |
There was a problem hiding this comment.
This makes line below stale
| // | ||
| // - Different power of two sizes. | ||
| // - Change it to be a non-even. | ||
| // MAX_LEAF_VALUE_SIZE is 1332, |
There was a problem hiding this comment.
perhaps we should consider re-exporting it with doc(hidden)?
There was a problem hiding this comment.
Yes, I can't recall where or when but I had to hardcode MAX_LEAF_VALUE_SIZE also another time. It could be useful, yes!
pepyakin
changed the base branch from
gm_long_rollback_test
to
graphite-base/725
+ more sophisticated new key generation + more sophisticated value generation + use the `max_rollback_blocks` cli argument as nomt option for `max_rollback_log_len`
pepyakin
force-pushed
the
gm_adderess_some_left_todos
branch
from
da7991a to
acf4507
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More sophisticated value generation.
Use the
max_rollback_blockscli argument as nomt option formax_rollback_log_len.More sophisticated new key generation.
To prove my claim on the amount of probabilities for a given amount of shared bytes, you can check some tests I did here.