Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): edgeless connector toolbar config extension #10798

Draft
wants to merge 1 commit into
base: fundon/03_12_refactor_edgeless_brush_toolbar_config_extension
Choose a base branch
from

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Mar 12, 2025

No description provided.

Copy link
Contributor Author

fundon commented Mar 12, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fundon fundon force-pushed the fundon/03_12_refactor_edgeless_connector_toolbar_config_extension branch from e9c0884 to 6c0354e Compare March 12, 2025 15:52
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 31.30435% with 79 lines in your changes missing coverage. Please review.

Project coverage is 54.24%. Comparing base (a293c61) to head (6c0354e).

Files with missing lines Patch % Lines
...ock-root/src/edgeless/configs/toolbar/connector.ts 32.40% 73 Missing ⚠️
...te/affine/blocks/block-note/src/configs/toolbar.ts 0.00% 5 Missing ⚠️
...s/block-root/src/edgeless/configs/toolbar/frame.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                                        Coverage Diff                                        @@
##           fundon/03_12_refactor_edgeless_brush_toolbar_config_extension   #10798      +/-   ##
=================================================================================================
- Coverage                                                          54.27%   54.24%   -0.03%     
=================================================================================================
  Files                                                               2408     2408              
  Lines                                                             110389   110497     +108     
  Branches                                                           18282    18316      +34     
=================================================================================================
+ Hits                                                               59910    59942      +32     
- Misses                                                             49176    49252      +76     
  Partials                                                            1303     1303              
Flag Coverage Δ
server-test 79.29% <ø> (-0.01%) ⬇️
unittest 31.00% <13.91%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fundon fundon force-pushed the fundon/03_12_refactor_edgeless_connector_toolbar_config_extension branch from 6c0354e to 1d09e28 Compare March 13, 2025 02:26
@fundon fundon force-pushed the fundon/03_12_refactor_edgeless_brush_toolbar_config_extension branch from a293c61 to 3bc0681 Compare March 13, 2025 02:46
@fundon fundon force-pushed the fundon/03_12_refactor_edgeless_connector_toolbar_config_extension branch from 1d09e28 to d7af7c9 Compare March 13, 2025 02:46
@fundon fundon force-pushed the fundon/03_12_refactor_edgeless_connector_toolbar_config_extension branch from d7af7c9 to c5e857a Compare March 13, 2025 06:56
@fundon fundon force-pushed the fundon/03_12_refactor_edgeless_brush_toolbar_config_extension branch from 3bc0681 to e6cfe23 Compare March 13, 2025 11:03
@fundon fundon force-pushed the fundon/03_12_refactor_edgeless_connector_toolbar_config_extension branch 2 times, most recently from b908c2b to d157044 Compare March 13, 2025 11:25
@fundon fundon force-pushed the fundon/03_12_refactor_edgeless_connector_toolbar_config_extension branch from d157044 to a2cf3d3 Compare March 13, 2025 13:26
@fundon fundon force-pushed the fundon/03_12_refactor_edgeless_brush_toolbar_config_extension branch from c0e7be4 to db22fbd Compare March 13, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant