Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): edgeless shape toolbar config extension #10821

Draft
wants to merge 1 commit into
base: fundon/03_13_refactor_edgeless_text_toolbar_config_extension
Choose a base branch
from

Conversation

fundon
Copy link
Contributor

@fundon fundon commented Mar 13, 2025

No description provided.

Copy link
Contributor Author

fundon commented Mar 13, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 57.40741% with 23 lines in your changes missing coverage. Please review.

Please upload report for BASE (fundon/03_13_refactor_edgeless_text_toolbar_config_extension@c522ea5). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...s/block-root/src/edgeless/configs/toolbar/shape.ts 47.61% 21 Missing and 1 partial ⚠️
...s/block-root/src/edgeless/configs/toolbar/frame.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                                       Coverage Diff                                       @@
##             fundon/03_13_refactor_edgeless_text_toolbar_config_extension   #10821   +/-   ##
===============================================================================================
  Coverage                                                                ?   54.14%           
===============================================================================================
  Files                                                                   ?     2439           
  Lines                                                                   ?   111309           
  Branches                                                                ?    18503           
===============================================================================================
  Hits                                                                    ?    60264           
  Misses                                                                  ?    49679           
  Partials                                                                ?     1366           
Flag Coverage Δ
server-test 79.32% <ø> (?)
unittest 30.91% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fundon fundon force-pushed the fundon/03_13_refactor_edgeless_shape_toolbar_config_extension branch 3 times, most recently from 6390f6b to 5719606 Compare March 13, 2025 11:25
@fundon fundon force-pushed the fundon/03_13_refactor_edgeless_text_toolbar_config_extension branch from c522ea5 to 8b61550 Compare March 13, 2025 13:26
@fundon fundon force-pushed the fundon/03_13_refactor_edgeless_shape_toolbar_config_extension branch from 5719606 to b7b0e5c Compare March 13, 2025 13:26
@fundon fundon force-pushed the fundon/03_13_refactor_edgeless_shape_toolbar_config_extension branch from b7b0e5c to 7731436 Compare March 13, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant