This repository was archived by the owner on Jun 22, 2023. It is now read-only.
feat(schema): Add rdau:P60537 (medium of performance) field #173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42
Useful in MusicComposition and MediaObject to indicate instrumentation
As discussed in this issue, and in slack recently.
Need confirmation that this is correct in the context:
"rdau": "http://rdaregistry.info/Elements/u/"
We decided to use library of congress performance mediums, but this patch doesn't verify that the value of the field is a URL. If we want to add this we should modify
additionalTypeFieldTransformer
to be a generic is-a-url transformer checker.Example mutation:
resulting json-ld output (edited)