This repository was archived by the owner on Jun 22, 2023. It is now read-only.
feat(json-jd): Allow ItemList.item to be an external URL #183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CE model of ItemList allowed us to only link to existing items in the CE, but in linked data there's nothing stopping this from linking to an external URL. This allows us to make a list of things external to the CE.
This follows the same pattern that we use in the annotation models where we have separate fields for either a link to an item in the CE, or a text field linking to an external resource.
This PR requires #173 and #182 to be merged before it, and we also need to modify the
validUrlFieldTransformer
in #173 to also validate this field.Items in the CE render like this:
and as json-ld like this:
or